Page MenuHomePhabricator

Move language-specific logos from Commons.css to logos.php at wikidatawiki
Open, Needs TriagePublic

Description

Wikidata has a set of language-specific logo variants defined in its MediaWiki:Common.css page. Currently it does not support HIDPI logos, and it is discouraged to define logo overrides in CSS rules, we should consider migrate these rules to wmf-config/logos.php.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

There's a request for adding pa language's logo. This is covered in this task.

Change 860117 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] wikidatawiki: Add language-specific logos

https://gerrit.wikimedia.org/r/860117

@Stang Hi, I noticed en and bn version here https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/860117/ looks littile different. So, i took some time and updated https://commons.wikimedia.org/wiki/File:Wikidata-logo-bn.svg. It would be great if you update it here as well. Thank you.

@Stang Hi, I noticed en and bn version here https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/860117/ looks littile different. So, i took some time and updated https://commons.wikimedia.org/wiki/File:Wikidata-logo-bn.svg. It would be great if you update it here as well. Thank you.

Done.

Change 860117 merged by jenkins-bot:

[operations/mediawiki-config@master] wikidatawiki: Add language-specific logos

https://gerrit.wikimedia.org/r/860117

Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:19:32Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:860117|wikidatawiki: Add language-specific logos (T323734)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:20:52Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and stang: Backport for [[gerrit:860117|wikidatawiki: Add language-specific logos (T323734)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Note that the patch also reduces the visual size of the main / English logo at 100% zoom (left is old / without the patch, right is new / with the patch):

image.png (314×556 px, 21 KB)

The PNG file now has the same width as most other project logos, 135px; I can’t say whether the visual change is good or not. (At 150% and 200%, there’s no difference; I don’t know whether the -1.5x and -2x files were inconsistent with the main file before or are inconsistent now.) I’ll still deploy this change, but it might need a follow-up.

Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:36:56Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:860117|wikidatawiki: Add language-specific logos (T323734)]] (duration: 17m 24s)

Mentioned in SAL (#wikimedia-operations) [2022-11-24T14:37:55Z] <Lucas_WMDE> lucaswerkmeister-wmde@mwmaint1002:~$ printf 'https://en.wikipedia.org/static/images/project-logos/wikidatawiki%s.png\n' '' '-1.5x' '-2x' | mwscript purgeList.php # T323734

I have removed the override in MediaWiki:Common.css

Note that the patch also reduces the visual size of the main / English logo at 100% zoom (left is old / without the patch, right is new / with the patch):

image.png (314×556 px, 21 KB)

The PNG file now has the same width as most other project logos, 135px; I can’t say whether the visual change is good or not. (At 150% and 200%, there’s no difference; I don’t know whether the -1.5x and -2x files were inconsistent with the main file before or are inconsistent now.) I’ll still deploy this change, but it might need a follow-up.

All project logos seem to have the same sizing properties applied to them now, and are almost identical in size. What appears to be causing the visual difference between the previous and the new Wikidata logo is the extra horizontal white space that exists around Wikidata's logo in the png file. That difference in the horizontal margins is making Wikidata's logo appear optically smaller in context, in comparison to the equally sized logos (the same is happening with the Commons logo, for example):

enwiki-2x.png (310×270 px, 19 KB)
wikidatawiki-2x.png (190×269 px, 2 KB)
commonswiki-2x.png (310×270 px, 10 KB)

The resizing made this more obvious, and now it's easy to perceive how Wikidata's logo is not aligned with the content in the main menu (as Wikipedia's is).
There are a couple of solutions we could apply if we want to make the logo look aligned with the menu's content again: 1. Increase the background-size applied to the Wikidata logo to compensate for the extra white space: I find 146px is a soft spot (although this would introduce an inconsistency in a code that now's nicely aligned), or 2. Create a new logo file with reduced margin.
I think it's also perfectly justifiable if we wanted to leave this as is: the optical misalignment is not inconsistent, it's not causing any UX nor severe layout issues. It's also only affecting the 'old'/Vector legacy look. Thoughts?

I don’t think we should increase the background-size with the current file, since that makes the file look a bit blurry. IMHO, both of the other approaches (new file with less margin, or do nothing) are fine.

Can you add the Nepali logo as well for Wikidata. Thanks

Change 860974 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] wikidatawiki: Add ne language logo variant

https://gerrit.wikimedia.org/r/860974

Change 860974 merged by jenkins-bot:

[operations/mediawiki-config@master] wikidatawiki: Add ne language logo variant

https://gerrit.wikimedia.org/r/860974

Mentioned in SAL (#wikimedia-operations) [2022-11-28T14:26:36Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:860974|wikidatawiki: Add ne language logo variant (T323734)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-28T14:27:36Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and stang: Backport for [[gerrit:860974|wikidatawiki: Add ne language logo variant (T323734)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-28T14:32:29Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:860974|wikidatawiki: Add ne language logo variant (T323734)]] (duration: 05m 52s)

Can you add the Nepali logo as well for Wikidata. Thanks

Done.