Page MenuHomePhabricator

UserImpact: Adjust time zone correction for page view URLs
Closed, DeclinedPublic

Description

This is a follow-up from the abandoned patch for T313310: Impact module: Implement table list component. Let's make sure we are adjust timezones correctly when constructing page view URLs. This comment has more information.

Steps to replicate the issue (include links if applicable):

  • Go to Preferences > Appereance > Time offset and select a timezone that creates "a one day offset" with the wiki server time.
  • For an edited article showing pageviews in the user impact module check the startDate query parameter on the articles pageviews urls.

What happens?:
The pageviews url startDate is in the server time (default UTC).

What should have happened instead?:
The pageviews url startDate should be in the user's preferred timezone

Other information (browser name/version, screenshots, etc.):

This can be also seen by checking the date of edition in the history view of an article.

Check revision date
Screenshot 2023-01-30 at 13.15.09.png (758×2 px, 203 KB)
Change user timezone
Screenshot 2023-01-30 at 13.14.30.png (506×1 px, 49 KB)
Check revision date in user's local time
Screenshot 2023-01-30 at 13.15.31.png (742×2 px, 204 KB)
Edit another article to force a refresh of user impact data
Check startDate in newcomers Homepage
Screenshot 2023-01-30 at 13.15.52.png (1×2 px, 426 KB)

Event Timeline

Change 862242 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] UserImpact: Set a specific end date for pageviews application URL

https://gerrit.wikimedia.org/r/862242

Change 862242 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] UserImpact: Set a specific end date for pageviews application URL

https://gerrit.wikimedia.org/r/862242

This patch handles the "end" parameter corresponding to the page view data we receive back from the Analytics Query Service. This task is still open for handling the "start" parameter.

Change 862242 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] UserImpact: Set a specific end date for pageviews application URL

https://gerrit.wikimedia.org/r/862242

Change 862347 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] UserImpact: Set a specific end date for pageviews application URL

https://gerrit.wikimedia.org/r/862347

Change 862347 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] UserImpact: Set a specific end date for pageviews application URL

https://gerrit.wikimedia.org/r/862347

Change 882639 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: adjust pageviews url so the start date is in the user timeone

https://gerrit.wikimedia.org/r/882639

Sgs changed the task status from Open to In Progress.Jan 23 2023, 12:15 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 882639 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] User impact: adjust pageviews url so the start date is in the user timezone

Reason:

See comments

https://gerrit.wikimedia.org/r/882639

Per team discussion this task is no longer valid. We'll file a new one in case we want to change the status quo of how dates are shown in the impact module.