Page MenuHomePhabricator

Recreate browser tests for detecting edit conflicts after form resubmission
Open, Needs TriagePublic

Description

We used to have browser tests that assert that an edit conflict is detected if the same form is submitted twice. However, for some reasons they did not work in CI, and so they were skipped a long time ago. Quick attempts to fix the underlying problem were not successful (see Reenable browser test to check for edit conflicts (I4df0ff86)).

So, those tests were effectively dead code for a long time and thus deleted: selenium: Delete tests disabled for more than 1 year (I9507e539)

However, we may still wish to verify that behavior.

Acceptance criteria:

  • there exists a test that asserts that the edit schema form detects an edit conflict when re-submitting the same form
  • there exists a test that asserts that the SetEntitySchemaLabelDescriptionAliasesPage detects an edit conflict when re-submitting the same form

Event Timeline

Change 859503 had a related patch set uploaded (by Michael Große; author: Zfilipin):

[mediawiki/extensions/EntitySchema@master] selenium: Delete tests disabled for more than 1 year

https://gerrit.wikimedia.org/r/859503

Change 813642 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Reenable browser test to check for edit conflicts

https://gerrit.wikimedia.org/r/813642

Change 813642 abandoned by Michael Große:

[mediawiki/extensions/EntitySchema@master] Reenable browser test to check for edit conflicts

Reason:

This did not work out. But what was tried here might be useful in the future. Further work will be tracked in T323763

https://gerrit.wikimedia.org/r/813642

Change 859503 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] selenium: Delete tests disabled for more than 1 year

https://gerrit.wikimedia.org/r/859503