Page MenuHomePhabricator
Create Task
Maniphest T323764

Consider breaking up EditFunction and CreateNewFunction FE integration tests
Closed, ResolvedPublic
Actions

Description

Description

These tests are currently extremely long, and test several edge cases. We should consider pulling the edge cases into separate files, and restricting these files to the most likely user actions.

See:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/tests/jest/integration/CreateNewFunction.test.js
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/tests/jest/integration/EditFunction.test.js

Completion checklist

Details

SubjectRepoBranchLines +/-
Break out edge cases from the main EditFunction and CreateNewFunction integration tests.mediawiki/extensions/WikiLambdamaster+264 -104
Customize query in gerrit

Event Timeline

EWright created this task.Nov 24 2022, 1:00 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Nov 29 2022, 7:40 PM
Jdforrester-WMF moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.
Ddwaal claimed this task.Dec 5 2022, 3:03 PM
gerritbot added a comment.Dec 5 2022, 10:05 PM

Change 864811 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Break out edge cases from the main EditFunciton and CreateNewFunction integration tests.

https://gerrit.wikimedia.org/r/864811

gerritbot added a project: Patch-For-Review.Dec 5 2022, 10:05 PM
gerritbot added a comment.Dec 6 2022, 4:51 PM

Change 864811 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Break out edge cases from the main EditFunction and CreateNewFunction integration tests.

https://gerrit.wikimedia.org/r/864811

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 6 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 6 2022, 5:31 PM
Ddwaal closed this task as Resolved.Dec 6 2022, 5:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL