Page MenuHomePhabricator

tinyrgb is distributed via puppet
Open, In Progress, Needs TriagePublic

Description

Currently we distribute the tinyrgb ColorSync colour profile via Puppet. This isn't ideal but is how we've always done things since migrating the Thumbor infra to puppet. In future we will be unable to use Puppet for this. tinyrgb is a binary file.

I see three options here:

  • Add the file to deployment-charts and distribute with the thumbor chart (unworkable, binaries in deployment-charts is a bad idea)
  • Package the file and distribute via apt (ideal imo)
  • Add to the thumbor repo and distribute as part of the Docker image (path of least resistance)

Currently I am inclined to do number 3 for the short term of migration with the objective of ultimately doing number 2.

Event Timeline

hnowlan changed the task status from Open to In Progress.Thu, Nov 24, 4:30 PM
hnowlan updated the task description. (Show Details)

Change 860628 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/deployment-charts@master] thumbor: correct tinyrgb path

https://gerrit.wikimedia.org/r/860628

Change 860580 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/software/thumbor-plugins@master] Add tinyrgb colour profile

https://gerrit.wikimedia.org/r/860580

Change 860580 merged by jenkins-bot:

[operations/software/thumbor-plugins@master] Add tinyrgb colour profile

https://gerrit.wikimedia.org/r/860580

Change 861367 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/deployment-charts@master] thumbor: new release

https://gerrit.wikimedia.org/r/861367

Change 861367 merged by jenkins-bot:

[operations/deployment-charts@master] thumbor: new release

https://gerrit.wikimedia.org/r/861367

Change 861383 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/deployment-charts@master] thumbor: Correct paths for 3d2png and tinyrgb

https://gerrit.wikimedia.org/r/861383

There's also a fourth option that comes to my mind:

Debian already ships various ICC profiles, in two separate packages:
https://tracker.debian.org/pkg/icc-profiles-free
https://tracker.debian.org/pkg/icc-profiles (this packages contains ICC profiles which don't meet the Debian Free Software Guidelines)

So if tinyrgb.icc is useful to anyone else besides our Thumbor use case, we could also file a bug in Debian to get it included within one of the two packages and then switch to installing the ICC profile package from Debian.

Change 861383 merged by jenkins-bot:

[operations/deployment-charts@master] thumbor: Correct paths for 3d2png and tinyrgb

https://gerrit.wikimedia.org/r/861383

The most obvious thing to me is to include the file in the thumbor docker image. It's ok to have a small binary that doesn't change much in it.