Page MenuHomePhabricator
Create Task
Maniphest T323831

🎬️ mobile-de-11 | Add "Remind me later" feature to the micro banner | ⏰ Nov 28th
Closed, ResolvedPublic
Actions

Description

Test Scope
We want to test the effect of moving the e-mail notification feature ("Remind me later") into the micro banner.

Acceptance Criteria

  • The banners are based on control banner of mobile-de-10.
  • The additional control banner height that was introduced to match the variant's height is removed again.
  • The variant micro banner has a third button below the existing two (similar to design file).
  • The button is labelled as "Erinnerung per E-Mail".
  • Clicking on the button
    • opens the e-mail address form overlay introduced in the variant of mobile-de-10.
    • stops the banner close countdown.

Banner Preview
control banner
variant banner

Related Objects
Search...

Event Timeline

kai.nissen created this task.Nov 25 2022, 3:27 PM
kai.nissen updated the task description. (Show Details)Nov 25 2022, 3:29 PM
Maintenance_bot added a project: WMDE-FUN-Team.Nov 25 2022, 3:30 PM
kai.nissen renamed this task from 🎬️ mobile-de-11 | Test scope | ⏰ Nov 28th to 🎬️ mobile-de-11 | Add "Remind me later" feature to the micro banner | ⏰ Nov 28th.Nov 25 2022, 4:16 PM
kai.nissen moved this task from Backlog to Ready for Work on the WMDE-FUN-Funban-2022 board.Nov 25 2022, 5:15 PM
CorinnaHillebrand_WMDE moved this task from Ready for Work to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.Nov 26 2022, 10:05 AM
CorinnaHillebrand_WMDE claimed this task.Nov 26 2022, 11:31 AM
CorinnaHillebrand_WMDE added a comment.Nov 26 2022, 2:31 PM

PR https://github.com/wmde/fundraising-banners/pull/1140

CorinnaHillebrand_WMDE removed CorinnaHillebrand_WMDE as the assignee of this task.Nov 26 2022, 3:17 PM
CorinnaHillebrand_WMDE moved this task from In Progress / Deployment (max. 4 tasks) to Acceptance Testing (Banners) on the WMDE-FUN-Funban-2022 board.
CorinnaHillebrand_WMDE added a subscriber: CorinnaHillebrand_WMDE.
kai.nissen added a comment.Nov 28 2022, 9:40 AM

The second form page and the email address form overlay need a little tweaking:

  • The second form page should have a < Zurück element instead of an X.
  • The new button should have the same color as the others.
  • The checkbox label should be left aligned.
  • The font weight of all elements in the overlay is too high.

Screenshot from 2022-11-28 09-54-47.png (669×377 px, 72 KB)
Overlay in mobile-de-10-var

Screenshot from 2022-11-28 09-54-41.png (669×377 px, 56 KB)
Overlay in mobile-de-11-var

kai.nissen moved this task from Acceptance Testing (Banners) to Ready for Work on the WMDE-FUN-Funban-2022 board.Nov 28 2022, 9:40 AM
AbbanWMDE moved this task from Ready for Work to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.Nov 28 2022, 11:20 AM
AbbanWMDE moved this task from In Progress / Deployment (max. 4 tasks) to Acceptance Testing (Banners) on the WMDE-FUN-Funban-2022 board.Nov 28 2022, 11:36 AM
kai.nissen moved this task from Acceptance Testing (Banners) to Code Review (max. 4 tasks) on the WMDE-FUN-Funban-2022 board.Nov 28 2022, 12:25 PM
CorinnaHillebrand_WMDE moved this task from Code Review (max. 4 tasks) to Done on the WMDE-FUN-Funban-2022 board.Dec 1 2022, 12:55 PM
kai.nissen mentioned this in W2044 Welcome.Dec 5 2022, 12:23 PM
kai.nissen closed this task as Resolved.Jan 4 2023, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL