Page MenuHomePhabricator
Create Task
Maniphest T323833

"Add topic" button gets duplicated when previewing and saving in mobile DiscussionTools
Closed, ResolvedPublic
Actions

Description

"Add topic" button gets duplicated when previewing and saving in mobile DiscussionTools.

In T317467#8420731, @EAkinloose wrote:

Kindly check https://photos.app.goo.gl/CUQpULgCMrcUmLuU9 (Android) and https://photos.app.goo.gl/9kos7kjvG6B8mVWdA (iOS) out, something funky is up.

context: Testing for Discussion tools on https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:TestUserEsther

For clarity, the funky behaviour isn't an enwiki beta thing, it's a DT thing from observation.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use 'BeforePageDisplay' instead of 'OutputPageBeforeHTML' for once-per-page thingsmediawiki/extensions/DiscussionToolsmaster+36 -36
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Nov 25 2022, 3:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2022, 3:58 PM
matmarex mentioned this in T317467: Enable DiscussionTools mobile on beta en.wiki, disable MobileFrontend talk page selenium test.Nov 25 2022, 4:01 PM
gerritbot added a comment.Nov 25 2022, 4:12 PM

Change 858618 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Use 'BeforePageDisplay' instead of 'OutputPageBeforeHTML' for once-per-page things

https://gerrit.wikimedia.org/r/858618

gerritbot added a project: Patch-For-Review.Nov 25 2022, 4:12 PM
matmarex claimed this task.Nov 25 2022, 4:13 PM

This turns out to be the same problem as T316175#8405061 and T323376, and my patch for those issues works to fix it.

matmarex added a project: Editing-team (Kanban Board).Nov 25 2022, 4:13 PM
matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Nov 28 2022, 3:23 PM

Change 858618 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use 'BeforePageDisplay' instead of 'OutputPageBeforeHTML' for once-per-page things

https://gerrit.wikimedia.org/r/858618

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2022, 3:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 28 2022, 4:01 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 29 2022, 2:05 PM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Nov 29 2022, 4:48 PM

✅ "Add topic" button isn't duplicated when previewing and saving in mobile DiscussionTools
https://photos.app.goo.gl/HhELCdNEhkiY25uR7

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 29 2022, 4:49 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Dec 1 2022, 4:11 PM
ppelberg closed this task as Resolved.Dec 2 2022, 12:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits