Page MenuHomePhabricator
Create Task
Maniphest T323860

In the VisualEditor options menu on MonoBook, the image icons overlap with the text
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Click edit (with VisualEditor) and pick an area where the options menu opens up (categories, templates, etc,)
  • The image icons overlap with the text

What happens?:

image.png (455×698 px, 49 KB)

What should have happened instead?:
The image icons shouldn't overlap with the text.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Google Chrome 107.0.5304.107
Windows 10

Note: this is my first time filing a Phabricator ticket, hope I didn't mess anything up!

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.46.0mediawiki/coremaster+139 -85
OutlineOptionWidget: Fix setting default indent leveloojs/uimaster+1 -0
Customize query in gerrit

Event Timeline

JCW555 created this task.Nov 27 2022, 3:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2022, 3:31 AM
JCW555 updated the task description. (Show Details)Nov 27 2022, 3:38 AM
JCW555 removed a project: VisualEditor-ContentEditable.Nov 27 2022, 4:03 AM
matmarex added a project: OOUI.Nov 28 2022, 2:46 PM
matmarex subscribed.

Thanks for the bug report; The issue is also reproducible in the OOUI demos: https://doc.wikimedia.org/oojs-ui/master/demos/?page=dialogs&theme=apex&direction=ltr&platform=desktop (click "Outlined booklet dialog").

image.png (773×1 px, 48 KB)

gerritbot added a comment.Nov 28 2022, 2:46 PM

Change 861394 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] OutlineOptionWidget: Fix setting default indent level

https://gerrit.wikimedia.org/r/861394

gerritbot added a project: Patch-For-Review.Nov 28 2022, 2:46 PM
gerritbot added a comment.Nov 28 2022, 3:55 PM

Change 861394 merged by jenkins-bot:

[oojs/ui@master] OutlineOptionWidget: Fix setting default indent level

https://gerrit.wikimedia.org/r/861394

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2022, 4:30 PM
• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Dec 1 2022, 4:37 PM
• ppelberg added a project: Editing-team (Kanban Board).
• ppelberg moved this task from Incoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
gerritbot added a comment.Dec 7 2022, 3:38 PM

Change 865677 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.46.0

https://gerrit.wikimedia.org/r/865677

gerritbot added a project: Patch-For-Review.Dec 7 2022, 3:38 PM
gerritbot added a comment.Dec 7 2022, 6:58 PM

Change 865677 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.46.0

https://gerrit.wikimedia.org/r/865677

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 7 2022, 7:01 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2022, 7:30 PM
matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Dec 7 2022, 9:29 PM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Dec 12 2022, 5:44 PM
EAkinloose subscribed.

✅ In the VisualEditor options menu on MonoBook, the image icons should not overlap with the text

Screenshot 2022-12-12 at 17.41.18.png (1×1 px, 152 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Dec 12 2022, 5:44 PM
• ppelberg closed this task as Resolved.Dec 19 2022, 5:59 PM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL