Page MenuHomePhabricator
Create Task
Maniphest T323877

Tagging adds blank lines both above and below the maintenance tag
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Tag an article with a single tag (not multiple) using the page curation toolbar

What happens?: A blank line is added both above and below the maintenance tag.

What should have happened instead?: A blank line is added only below the maintenance tag, not above.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

See https://en.wikipedia.org/w/index.php?title=1900_(special)&diff=1124205366&oldid=1124179676 for an example.

The extra blank line is added only if a single maintenance tag was added, not multiple. If multiple maintenance tags were added, then is no blank line added above the "Multiple issues" template, as in https://en.wikipedia.org/w/index.php?title=Sarnitsa_Municipality&diff=1124134794&oldid=1124031131.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't add newline to top of page when applying maintenance tagsmediawiki/extensions/PageTriagemaster+12 -6
Customize query in gerrit

Event Timeline

GTrang created this task.Nov 27 2022, 9:44 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 27 2022, 9:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae moved this task from Backlog to Other bugs on the PageTriage board.Nov 28 2022, 1:25 AM
gerritbot added a comment.Nov 28 2022, 5:52 AM

Change 861006 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Don't add newline to top of page when applying maintenance tags

https://gerrit.wikimedia.org/r/861006

gerritbot added a project: Patch-For-Review.Nov 28 2022, 5:52 AM
Novem_Linguae moved this task from Other bugs to Code Review on the PageTriage board.Nov 28 2022, 5:56 AM
Novem_Linguae claimed this task.Nov 28 2022, 5:59 AM
gerritbot added a comment.Nov 28 2022, 10:53 AM

Change 861006 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Don't add newline to top of page when applying maintenance tags

https://gerrit.wikimedia.org/r/861006

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 28 2022, 11:01 AM
MPGuy2824 moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Nov 28 2022, 11:10 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 28 2022, 11:30 AM
Sgs moved this task from Inbox to Triaged on the Growth-Team board.Nov 30 2022, 11:23 AM
MPGuy2824 closed this task as Resolved.Dec 2 2022, 2:57 AM
MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits