Page MenuHomePhabricator
Create Task
Maniphest T324032

Create ADR about decision to validate in the REST API deserializers
Closed, ResolvedPublic
Actions

Description

The Wikibase DataModel deserializers don't fully validate during deserialization (i.e. they can produce invalid objects). It was decided that the deserializers in the Wikibase REST API will do validation during deserialization. This decision should be documented in an ADR.

Details

SubjectRepoBranchLines +/-
REST: Add "validate fully in deserializers" ADRmediawiki/extensions/Wikibasemaster+33 -0
Customize query in gerrit

Event Timeline

Ollie.Shotton_WMDE created this task.Nov 29 2022, 4:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2022, 4:04 PM
Ollie.Shotton_WMDE claimed this task.Feb 14 2023, 9:10 AM
Ollie.Shotton_WMDE moved this task from Non Product to Sprint 23 on the Wikibase Product Platform (v1) board.
Ollie.Shotton_WMDE edited projects, added Wikibase Product Platform (v1) (Sprint 23); removed Wikibase Product Platform (v1).
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 24); removed Wikibase Product Platform (v1) (Sprint 23).Feb 28 2023, 10:25 AM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 24) board.Mar 7 2023, 11:51 AM
gerritbot added a comment.Mar 8 2023, 5:15 PM

Change 895835 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Add "validate fully in deserializers" ADR

https://gerrit.wikimedia.org/r/895835

gerritbot added a project: Patch-For-Review.Mar 8 2023, 5:15 PM
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 24) board.Mar 8 2023, 5:23 PM
Silvan_WMDE moved this task from Sprint 24 to Sprint 25 on the Wikibase Product Platform (v1) board.Mar 14 2023, 10:33 AM
Silvan_WMDE edited projects, added Wikibase Product Platform (v1) (Sprint 25); removed Wikibase Product Platform (v1) (Sprint 24).
Silvan_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 25) board.
gerritbot added a comment.Mar 17 2023, 10:22 AM

Change 895835 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add "validate fully in deserializers" ADR

https://gerrit.wikimedia.org/r/895835

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 25) board.Mar 17 2023, 10:26 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2023, 10:30 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 17 2023, 11:00 AM
WMDE-leszek closed this task as Resolved.Apr 19 2023, 2:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL