Page MenuHomePhabricator

Verify DiscussionTools and VisualEditor work correctly in all content width configurations (Vector2022)
Closed, ResolvedPublic

Description

T319449, and the en.wiki RFC that preceded it, will result in it being possible for people to view content at full-width within the Vector 2022 skin.

This is a change from what had previously been a set content width. Along with it, we ought to verify that the various editing experiences the Editing Team maintains continue to work as expected in the Vector 2022 skin.

Requirements

Using Wikipedia with the Vector (2022) preference enabled and content width toggle set to narrow, verify the:

  • visual editor (and 2017 wikitext editor)
  • DiscussionTools
    • Reply Tool and New Topic Tool
    • Suite of Usability Improvements (Topic Containers, Clear Affordances, and Page Frame)

...all work as expected

NOTE: please be sure to adjust the state of the toggle while you're editing to ensure nothing unexpected happens.

Done

  • Complete the Requirements above and file tasks for any issues that any emerge while completing them.

Event Timeline

UPDATE
This should now be ready for testing.

To access the newly-implemented toggle that will enable you to test the interfaces listed in the task description using Vector 2022's new wider width:

  1. Visit: https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering
  2. Disable the Enable limited width mode setting:

Screen Shot 2022-12-08 at 10.57.00 AM.png (402×1 px, 57 KB)

UPDATE
This should now be ready for testing.

To access the newly-implemented toggle that will enable you to test the interfaces listed in the task description using Vector 2022's new wider width:

  1. Visit: https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering
  2. Disable the Enable limited width mode setting:

Screen Shot 2022-12-08 at 10.57.00 AM.png (402×1 px, 57 KB)

{F35864478}

{F35864479}

{F35864480}

{F35864481}

{F35864482}

{F35864483}

Screenshot 2022-12-12 at 18.27.51.png (922×2 px, 145 KB)

Screenshot 2022-12-12 at 18.26.53.png (1×2 px, 237 KB)

Screenshot 2022-12-12 at 18.27.45.png (1×2 px, 192 KB)

Screenshot 2022-12-12 at 18.37.56.png (1×3 px, 261 KB)

Screenshot 2022-12-12 at 18.33.00.png (644×2 px, 169 KB)

Screenshot 2022-12-12 at 18.35.23.png (1×1 px, 165 KB)

Screenshot 2022-12-12 at 18.33.42.png (732×2 px, 203 KB)

Screenshot 2022-12-12 at 18.27.00.png (1×2 px, 240 KB)

Assigning this over to Ed to address the findings @EAkinloose shared in T324043#8468804.

No issue

{F35864478}

{F35864479}

{F35864480}

{F35864481}

{F35864482}

{F35864483}

Screenshot 2022-12-12 at 18.27.51.png (922×2 px, 145 KB)

Screenshot 2022-12-12 at 18.26.53.png (1×2 px, 237 KB)

Screenshot 2022-12-12 at 18.27.45.png (1×2 px, 192 KB)

Screenshot 2022-12-12 at 18.37.56.png (1×3 px, 261 KB)

Screenshot 2022-12-12 at 18.33.00.png (644×2 px, 169 KB)

Screenshot 2022-12-12 at 18.35.23.png (1×1 px, 165 KB)

Screenshot 2022-12-12 at 18.33.42.png (732×2 px, 203 KB)

Screenshot 2022-12-12 at 18.27.00.png (1×2 px, 240 KB)

✅ Confirmed that these elements adjust with the width. Will keep an eye out for anything that could come up later. We should be good for now.