cron and maintenance cleanup
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Novem_Linguae
	Nov 30 2022, 9:59 AM

Description

Search around and see which cron jobs are still in use
- cron/updatePageTriageQueue.php is still in use and runs every 48 hours on enwiki, testwiki, and test2wiki. Link to Puppet.
- Consider moving cron/updateUserMetadata.php to the /maintenance/ folder, does not appear to be in use as a cron job
- Add comments. For example, cron/updatePageTriageQueue.php should probably mention the 48 hour interval and include the above Puppet link.
- Figure out if PageTriage has an install guide either in the repo as a .md file, or at mw:Extension:PageTriage in a section. If existing file found, update it to include a step about setting up this 48 hour cron job on Puppet. If no install guide yet, create it.
cron/updatePageTriageQueue.php has use X; statements on lines 3, and lines 11-12. Is it safe to move lines 11-12 up to be with line 3? If so, move them up.
cron/* and maintenance/* contain some imperative code with a big class in the middle. These classes should be factored out into includes/Maintenance/ for testability.
Figure out how to manually test cron jobs and maintenance jobs, to make sure we don't break them when we refactor them.

	Subject	Repo	Branch	Lines +/-
	cleanup: Move tools maintenance scripts into maintenance directory	mediawiki/extensions/PageTriage	master	+0 -0
	Move unused cron job to maintenance folder	mediawiki/extensions/PageTriage	master	+6 -0

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 863939 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Move unused cron job to maintenance folder

Change 863252 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] cleanup: Move tools maintenance scripts into maintenance directory

Change 863939 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Move unused cron job to maintenance folder

Change 863252 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] cleanup: Move tools maintenance scripts into maintenance directory

Novem_Linguae claimed this task.

Novem_Linguae updated the task description. (Show Details)