We chose to try out PHPat for enforcing the dependency rules within the Wikibase REST API namespaces.
This was partially done in this patch: https://gerrit.wikimedia.org/r/865577
Checks for the following namespaces/layers:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jakob_WMDE | T324093 Enforce dependency rules with PHPat | |||
| Resolved | Jdforrester-WMF | T326653 PHPStan failing on Wikibase backports to wmf branches | |||
| Resolved | Jakob_WMDE | T333454 PHPStan failing on Wikibase backports to REL1_40 |
Change 865577 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Enforce dependency rules with phpat
Change 865577 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Enforce dependency rules with phpat
Change 902012 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Nest dependencies in PHPat test
Change 902099 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Enforce serialization namespace dependencies
Change 902106 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Enforce validation namespace dependencies
Change 902108 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Enforce presentation namespace dependencies
Change 902012 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Nest dependencies in PHPat test
Change 902099 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Enforce serialization namespace dependencies
Change 902687 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Allow DataValues as a domain model dependency
Change 902106 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Enforce validation namespace dependencies
Change 902108 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Enforce presentation namespace dependencies
Change 902687 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Allow DataValues as a domain model dependency
Since the task description mentions that this is to “try out” something (and the task is still open), I’ll mention that we had to remove the PHPStan check on the REL1_40 branch (see T333454), and unless a better solution is found, it’ll have to be removed on REL1_41, REL1_42 etc. as well.
Thanks for the shout. We like PHPat and are past the "try out" phase now and the task is in the done column, we just didn't close it yet.
I mentioned in our daily that T333454 is causing trouble and we'll very likely pick it up in the next sprint (in two weeks).