Maniphest T324149

Build a widget to display GitLab changes on related Phabricator tasks
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	brennen
	Nov 30 2022, 8:52 PM

Tags

Referenced Files

	F35825769: 2022-11-30-13:46:28.png
	Nov 30 2022, 8:52 PM

Subscribers

Tokens

"Like" token, awarded by valerio.bozzolan."Barnstar" token, awarded by thcipriani.

Description

Splitting this off from T265617: Experiment with GitLab-Phabricator integration.

There's a custom widget on our Phabricator instance that displays Gerrit patches associated to a Phab task with a Bug: trailer.

Here's an example:

@hashar discusses some of the implementation at T265617#7914463.

On the Phabricator side, this is handled by code in libext/misc/src/customfields/GerritPatchesCustomField.php.

I stubbed out a GitLabPatchesCustomField.php stubbed out, will push that somewhere.

Details

	Subject	Repo	Branch	Lines +/-
	phabricator config: add gitlab_api_key	operations/puppet	production	+3 -0

Customize query in gerrit

	Title	Reference	Author	Source Branch	Dest Branch
	GitLabPatchesCustomField: limit searching to only the Tnnn form	repos/phabricator/extensions!3	brennen	search-only-t-format	wmf/stable
	config template: add gitlab_api_key	repos/phabricator/deployment!2	brennen	work/gitlab-api-key	wmf/stable
	add GitLabPatchesCustomField to display merge requests that mention a task	repos/phabricator/extensions!1	brennen	review/brennen/mr-widget	wmf/stable

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T319359 GitLab integrations: the Gerrit & Jenkins integration catalog
		Open		None	T265617 Experiment with GitLab-Phabricator integration
		Resolved		brennen	T324149 Build a widget to display GitLab changes on related Phabricator tasks

Event Timeline

brennen created this task.Nov 30 2022, 8:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2022, 8:52 PM

brennen moved this task from Backlog to Next on the User-brennen board.Dec 5 2022, 9:27 PM

brennen moved this task from Backlog to In progress on the Release-Engineering-Team (GitLab III: GitLab in LA 🪃) board.Dec 6 2022, 10:11 PM

brennen moved this task from To Triage to Needs code (in Phab or bot) on the Phabricator board.Dec 13 2022, 10:01 PM

brennen edited projects, added Release-Engineering-Team (Holiday Leftovers 🥡); removed Release-Engineering-Team (GitLab III: GitLab in LA 🪃).Jan 11 2023, 5:47 PM

brennen moved this task from Backlog to In progress on the Release-Engineering-Team (Holiday Leftovers 🥡) board.

thcipriani edited projects, added Release-Engineering-Team (GitLab IV: Mise En Place 🍱); removed Release-Engineering-Team (Holiday Leftovers 🥡).Jan 19 2023, 3:45 PM

thcipriani moved this task from Backlog to In progress on the Release-Engineering-Team (GitLab IV: Mise En Place 🍱) board.Jan 19 2023, 3:46 PM

brennen moved this task from Next to Doing on the User-brennen board.Feb 6 2023, 6:05 PM

thcipriani triaged this task as Medium priority.Feb 13 2023, 4:25 PM

thcipriani edited projects, added Release-Engineering-Team (GitLab V: Event Horizon 🌄); removed Release-Engineering-Team (GitLab IV: Mise En Place 🍱).

thcipriani moved this task from Backlog to In progress on the Release-Engineering-Team (GitLab V: Event Horizon 🌄) board.

Comment bot was likely down earlier, but: WIP: add GitLabPatchesCustomField.

brennen changed the task status from Open to In Progress.Feb 14 2023, 12:28 AM

Change 889248 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/puppet@production] phabricator config: add gitlab_api_key

https://gerrit.wikimedia.org/r/889248

gerritbot added a project: Patch-For-Review.Feb 14 2023, 10:24 PM

Change 889248 merged by Dzahn:

[operations/puppet@production] phabricator config: add gitlab_api_key

https://gerrit.wikimedia.org/r/889248

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2023, 9:29 PM

brennen moved this task from In progress to Done on the Release-Engineering-Team (GitLab V: Event Horizon 🌄) board.Mar 8 2023, 5:11 PM

hashar unsubscribed.Mar 13 2023, 2:43 PM

brennen mentioned this in T331915: Phabricator deployment 2023-03-15.Mar 13 2023, 6:22 PM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/2

config template: add gitlab_api_key

brennen merged https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/1

add GitLabPatchesCustomField to display merge requests that mention a task

brennen opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/3

GitLabPatchesCustomField: limit searching to only the Tnnn form

gerritbot added a project: Patch-For-Review.Mar 15 2023, 4:22 AM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/3

GitLabPatchesCustomField: limit searching to only the Tnnn form

Deployed.

thcipriani awarded a token.Mar 15 2023, 10:32 PM

valerio.bozzolan awarded a token.Mar 15 2023, 11:02 PM

brennen mentioned this in T332607: GitLab MR widget sometimes errors out on a missing index.Mar 20 2023, 4:03 PM

brennen mentioned this in T332234: Cannot access workboard: Unhandled Exception: Undefined variable: other_assignees.

hashar mentioned this in T333347: Phabricator does not degrade properly when GitLab is unavailable.Mar 28 2023, 1:15 PM

eoghan mentioned this in T335504: Switchover gitlab (gitlab2002 -> gitlab1004).May 2 2023, 10:42 AM

brennen mentioned this in rPHDEP95a72c5481af: config template: add gitlab_api_key.Oct 28 2023, 10:19 AM

brennen mentioned this in rPHDEP0edb98db9728: extensions: mr widget: use T in search link.

brennen mentioned this in rPHDEP9278a3665dd7: extensions: mr widget: remove development task override.