Page MenuHomePhabricator

NewImpact: Visual design improvements to the "sparkline" style graph that shows pageviews over time
Closed, ResolvedPublic

Description

Not a blocker but there are some minor visual improvements to be made to the sparkline compared the the expected design:

Expected
image.png (1×1 px, 281 KB)
Actual:
Screen Shot 2022-11-29 at 6.53.29 PM.png (596×916 px, 98 KB)
iThere is a 2x2px dot denoting the final data point at the end of the lineNo dot
iiSmooth lineNoticeable 'bleeding' effect of blue running down to the x-axis.

Event Timeline

RHo updated the task description. (Show Details)

Change 875392 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: add circle to the articles pageviews chart and quantize views

https://gerrit.wikimedia.org/r/875392

The bleeding effect is due to the fact that we render many data points in a small area (up to 60 points on 20px x axis range). In the provided design the line is smooth because only 6 points are rendered. We can try to "quantize" the data ( split all data points in equal chunks and do the summation for each chunk) to only show 6 points if that makes sense. What do you think @RHo?

Sgs changed the task status from Open to In Progress.Jan 4 2023, 5:37 PM
Sgs claimed this task.
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

The bleeding effect is due to the fact that we render many data points in a small area (up to 60 points on 20px x axis range). In the provided design the line is smooth because only 6 points are rendered. We can try to "quantize" the data ( split all data points in equal chunks and do the summation for each chunk) to only show 6 points if that makes sense. What do you think @RHo?

Yes, that sounds like a good idea to try. Thanks @Sgs!

Change 875392 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: add circle to the articles pageviews chart and quantize views

https://gerrit.wikimedia.org/r/875392

kostajh changed the task status from In Progress to Open.Jan 9 2023, 5:08 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

These look great to me @Etonkovidova and much more in line with the expected visuals.

These look great to me @Etonkovidova and much more in line with the expected visuals.

Thanks, @KieranMcCann. Closing as Resolved.