Page MenuHomePhabricator

ParserCache save operations are misreported in Grafana
Closed, ResolvedPublic

Description

The "ParserCache save operations" panel on the Parser Cache dashboard are mis-reporting the number of operations. Most operations are currently counted twice.

This was caused by
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/853489. This patch which was intended to introduce a new metric, save-reason.*, distinct from the existing save.* keys. However, since the ParserCache::incrementStats function was incorrectly replacing all "." with "_" in metrics keys, we end up with the save_* and save_reason_* prefixes overlapping.

The solution is to change ParserCache so it uses distinc prefixes for the reason and the outcome of the save operation. Ideally, the pre-existing keys would be kapt as they used to be, and the key for the new metrics indicating the reason are changed to a distinct prefix.

Event Timeline

Change 862961 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] ParserCache: fix metrics keys

https://gerrit.wikimedia.org/r/862961

daniel renamed this task from ParserCache metrics are mis-reported to ParserCache save operations are misreported in Grafana.Dec 1 2022, 4:04 PM

Change 862961 merged by jenkins-bot:

[mediawiki/core@master] ParserCache: fix metrics keys

https://gerrit.wikimedia.org/r/862961