Maniphest T324272

Handle errors from DLocal SmartForms
Closed, ResolvedPublic
Actions

Description

add a 'change' eventListener to the field instance and display errors when the fired event has an error property.
- Clear errors when the event's error property is falsy
try to re-use existing error messages when possible, add new strings if needed

Details

	Subject	Repo	Branch	Lines +/-
	Handle errors from DLocal SmartForms	mediawiki/extensions/DonationInterface	master	+133 -15

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		AKanji-WMF	T274300 Upgrade Dlocal to leverage Smartfields/no redirect
		Resolved		Damilare	T324272 Handle errors from DLocal SmartForms

Event Timeline

Ejegg created this task.Dec 1 2022, 10:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2022, 10:52 PM

XenoRyet moved this task from Triage to dLocal Integration on the Fundraising-Backlog board.Dec 5 2022, 8:35 PM

XenoRyet moved this task from dLocal Integration to Current Sprint on the Fundraising-Backlog board.Dec 6 2022, 9:15 PM

XenoRyet added a project: Fundraising Sprint Wibbly Wobbly Timey Wimey.Dec 6 2022, 9:21 PM

Damilare claimed this task.Dec 12 2022, 1:46 PM

Damilare moved this task from Backlog to Doing on the Fundraising Sprint Wibbly Wobbly Timey Wimey board.

XenoRyet added a project: Fundraising Sprint Amazing grep.Jan 3 2023, 8:53 PM

Damilare moved this task from Backlog to Doing on the Fundraising Sprint Amazing grep board.Jan 5 2023, 2:28 PM

Change 880528 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Handle errors from DLocal SmartForms

https://gerrit.wikimedia.org/r/880528

gerritbot added a project: Patch-For-Review.Jan 16 2023, 6:44 PM

Damilare moved this task from Doing to Ready for Review on the Fundraising Sprint Amazing grep board.Jan 17 2023, 3:20 PM

XenoRyet added a project: Fundraising Sprint Bridge over troubled Wifi.Jan 17 2023, 9:18 PM

Damilare moved this task from Backlog to Ready for Review on the Fundraising Sprint Bridge over troubled Wifi board.Jan 18 2023, 12:59 PM

jgleeson moved this task from Backlog to One Hour Test on the FR-dlocal board.Jan 19 2023, 6:38 PM

jgleeson moved this task from One Hour Test to Internal Test on the FR-dlocal board.Jan 19 2023, 6:44 PM

Change 880528 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Handle errors from DLocal SmartForms

https://gerrit.wikimedia.org/r/880528

Ejegg moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint Bridge over troubled Wifi board.Jan 24 2023, 10:57 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 24 2023, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2023, 11:30 PM

Cstone moved this task from Pending Deployment to Blocked in sprint (not fr-tech) on the Fundraising Sprint Bridge over troubled Wifi board.Jan 31 2023, 8:15 PM

Cstone moved this task from Blocked in sprint (not fr-tech) to Done on the Fundraising Sprint Bridge over troubled Wifi board.

XenoRyet closed this task as Resolved.Jan 31 2023, 8:16 PM

XenoRyet set Final Story Points to 4.