Page MenuHomePhabricator
Create Task
Maniphest T324285

NewImpact: Null state for "Last edited"
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue

View the newcomer homepage with the new impact module enabled for KStoller-WMF

What happens?:

Because I communicate on English wikipedia talk pages with my staff account, I have received Thanks despite not having any article edits. So I see the new impact module rather than the empty state, but my "Last edit" is "53 years ago".

What should have happened instead?:

My last edit should be empty (similar to how my Longest streak is empty)
or
I should still see the empty state if total edits = 0.

Screen Shot 2022-12-01 at 4.44.41 PM.png (1,078×1,142 px, 100 KB)

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

KStoller-WMF created this task.Dec 2 2022, 12:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2022, 12:42 AM
KStoller-WMF added a parent task: T222310: [EPIC] Positive reinforcement: New Impact Module.Dec 2 2022, 12:43 AM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr subscribed.Dec 2 2022, 2:48 AM

This happens when the user has edits but no mainspace edits. ("53 years ago" is zero in Unix time, in case you were wondering.)

gerritbot added a comment.Dec 2 2022, 3:02 AM

Change 863088 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show the impact module if the user has no main edits

https://gerrit.wikimedia.org/r/863088

gerritbot added a project: Patch-For-Review.Dec 2 2022, 3:02 AM
Tgr claimed this task.Dec 2 2022, 3:02 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 2 2022, 11:42 AM

Change 863258 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show the impact module if the user has no main edits

https://gerrit.wikimedia.org/r/863258

Etonkovidova subscribed.Dec 2 2022, 6:30 PM

Testing note (to check after deployment) - check user Zilant17 on cawiki.

kostajh added a project: GrowthExperiments-ImpactModule.Dec 5 2022, 8:21 AM
kostajh moved this task from Triage to NewImpact Release Blocker on the GrowthExperiments-ImpactModule board.
gerritbot added a comment.Dec 6 2022, 6:14 AM

Change 864890 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Use a direct query for checking mainspace edits

https://gerrit.wikimedia.org/r/864890

gerritbot added a comment.Dec 6 2022, 7:38 AM

Change 863088 abandoned by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show the impact module if the user has no main edits

Reason:

per comments

https://gerrit.wikimedia.org/r/863088

gerritbot added a comment.Dec 6 2022, 8:44 AM

Change 864890 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Use a direct query for checking mainspace edits

Reason:

squashed into parent

https://gerrit.wikimedia.org/r/864890

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 6 2022, 8:46 AM
gerritbot added a comment.Dec 6 2022, 8:47 AM

Change 864908 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864908

gerritbot added a comment.Dec 6 2022, 8:47 AM

Change 864909 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864909

gerritbot added a comment.Dec 6 2022, 9:08 AM

Change 864908 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864908

Stashbot added a comment.Dec 6 2022, 9:09 AM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T09:09:27Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:864908|User impact: Do not show impact module if user has no mainspace edits (T324285)]]

Stashbot added a comment.Dec 6 2022, 9:11 AM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T09:11:41Z] <kharlan@deploy1002> kharlan and kharlan: Backport for [[gerrit:864908|User impact: Do not show impact module if user has no mainspace edits (T324285)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Dec 6 2022, 9:37 AM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T09:37:32Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:864908|User impact: Do not show impact module if user has no mainspace edits (T324285)]] (duration: 28m 05s)

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Dec 6 2022, 10:00 AM
gerritbot added a comment.Dec 6 2022, 12:51 PM

Change 863258 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/863258

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Dec 6 2022, 1:01 PM
gerritbot added a comment.Dec 6 2022, 1:44 PM

Change 865074 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/865074

gerritbot added a comment.Dec 6 2022, 1:47 PM

Change 864919 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/864919

gerritbot added a comment.Dec 6 2022, 2:07 PM

Change 865074 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/865074

gerritbot added a comment.Dec 6 2022, 2:11 PM

Change 864919 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/864919

Stashbot added a comment.Dec 6 2022, 2:12 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T14:11:54Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:864919|NewImpact: Adjust hasMainspaceEditsCache check (T324285)]]

Stashbot added a comment.Dec 6 2022, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T14:13:49Z] <kharlan@deploy1002> kharlan and kharlan: Backport for [[gerrit:864919|NewImpact: Adjust hasMainspaceEditsCache check (T324285)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Dec 6 2022, 2:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T14:20:59Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:864919|NewImpact: Adjust hasMainspaceEditsCache check (T324285)]] (duration: 09m 04s)

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28); removed: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 6 2022, 3:00 PM
kostajh moved this task from NewImpact Release Blocker to NewImpact Release (Completed/QA) on the GrowthExperiments-ImpactModule board.Dec 6 2022, 3:29 PM
gerritbot added a comment.Dec 6 2022, 3:42 PM

Change 864909 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864909

Stashbot mentioned this in T324286: NewImpact: edits and thanks are capped at 1000.Dec 6 2022, 3:43 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T15:43:30Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:864909|User impact: Do not show impact module if user has no mainspace edits (T324285)]], [[gerrit:865082|Localisation updates from https://translatewiki.net.]], [[gerrit:864911|NewImpact: Show "999+" when we could not count edits/thanks (T324286)]]

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05); removed: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Dec 6 2022, 4:01 PM
Stashbot added a comment.Dec 6 2022, 4:02 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T16:02:54Z] <kharlan@deploy1002> kharlan and urbanecm and kharlan: Backport for [[gerrit:864909|User impact: Do not show impact module if user has no mainspace edits (T324285)]], [[gerrit:865082|Localisation updates from https://translatewiki.net.]], [[gerrit:864911|NewImpact: Show "999+" when we could not count edits/thanks (T324286)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.

Stashbot added a comment.Dec 6 2022, 4:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T16:13:14Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:864909|User impact: Do not show impact module if user has no mainspace edits (T324285)]], [[gerrit:865082|Localisation updates from https://translatewiki.net.]], [[gerrit:864911|NewImpact: Show "999+" when we could not count edits/thanks (T324286)]] (duration: 29m 43s)

gerritbot added a comment.Dec 6 2022, 5:09 PM

Change 865115 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865115

gerritbot added a comment.Dec 6 2022, 9:42 PM

Change 865130 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865130

gerritbot added a comment.Dec 6 2022, 9:43 PM

Change 865131 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865131

gerritbot added a comment.Dec 6 2022, 9:46 PM

Change 865115 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865115

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 6 2022, 10:01 PM
gerritbot added a comment.Dec 6 2022, 10:06 PM

Change 865131 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865131

gerritbot added a comment.Dec 6 2022, 10:06 PM

Change 865130 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865130

Stashbot added a comment.Dec 6 2022, 10:07 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T22:07:11Z] <tgr@deploy1002> Started scap: Backport for [[gerrit:865131|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]], [[gerrit:865130|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]]

Stashbot added a comment.Dec 6 2022, 10:09 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T22:09:01Z] <tgr@deploy1002> tgr and tgr: Backport for [[gerrit:865131|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]], [[gerrit:865130|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Dec 6 2022, 10:26 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-06T22:26:09Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:865131|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]], [[gerrit:865130|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]] (duration: 18m 58s)

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05); removed: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 6 2022, 11:00 PM
gerritbot added a comment.Dec 7 2022, 5:22 AM

Change 865237 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper and add test

https://gerrit.wikimedia.org/r/865237

Tgr moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 7 2022, 5:23 AM
gerritbot added a comment.Dec 21 2022, 1:56 PM

Change 865237 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper and add test

https://gerrit.wikimedia.org/r/865237

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 21 2022, 2:00 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 9 2023, 5:08 PM
Etonkovidova added a comment.Jan 17 2023, 5:08 AM

The last patch - https://gerrit.wikimedia.org/r/865237 - never been deployed.
@Tgr - I don't see the null edit state for https://en.wikipedia.org/wiki/Special:Impact/KStoller-WMF and for my test user https://ca.wikipedia.org/wiki/Especial:Impacte/Zilant17. Both users have Thanks, e.g. Special:Log?type=thanks

kostajh subscribed.Jan 17 2023, 6:51 AM
In T324285#8530010, @Etonkovidova wrote:

The last patch - https://gerrit.wikimedia.org/r/865237 - never been deployed.

That patch has been merged but fixed a somewhat narrow issue.

@Tgr - I don't see the null edit state for https://en.wikipedia.org/wiki/Special:Impact/KStoller-WMF and for my test user https://ca.wikipedia.org/wiki/Especial:Impacte/Zilant17. Both users have Thanks, e.g. Special:Log?type=thanks

Just double-checking, are you expecting to see T322850: Add thanks and longest streak scorecards to the unactivated state? That one is not yet merged/deployed.

Etonkovidova added a comment.Jan 17 2023, 3:31 PM
In T324285#8530079, @kostajh wrote:
In T324285#8530010, @Etonkovidova wrote:

@Tgr - I don't see the null edit state for https://en.wikipedia.org/wiki/Special:Impact/KStoller-WMF and for my test user https://ca.wikipedia.org/wiki/Especial:Impacte/Zilant17. Both users have Thanks, e.g. Special:Log?type=thanks

Just double-checking, are you expecting to see T322850: Add thanks and longest streak scorecards to the unactivated state? That one is not yet merged/deployed.

Thx, @kostajh - yes, it seems that T322850: Add thanks and longest streak scorecards to the unactivated state will address that. I was just confused with the mockup in the task description. I was expecting it to be done in the scope of this task.

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 17 2023, 3:46 PM
Etonkovidova closed this task as Resolved.Feb 13 2023, 10:35 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 11:10 PM
KStoller-WMF mentioned this in T330614: New Impact module's empty state on mobile: research spike.Feb 27 2023, 3:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits