Page MenuHomePhabricator

NewImpact: Null state for "Last edited"
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue

View the newcomer homepage with the new impact module enabled for KStoller-WMF

What happens?:

Because I communicate on English wikipedia talk pages with my staff account, I have received Thanks despite not having any article edits. So I see the new impact module rather than the empty state, but my "Last edit" is "53 years ago".

What should have happened instead?:

My last edit should be empty (similar to how my Longest streak is empty)
or
I should still see the empty state if total edits = 0.

Screen Shot 2022-12-01 at 4.44.41 PM.png (1×1 px, 100 KB)

Event Timeline

This happens when the user has edits but no mainspace edits. ("53 years ago" is zero in Unix time, in case you were wondering.)

Change 863088 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show the impact module if the user has no main edits

https://gerrit.wikimedia.org/r/863088

Change 863258 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show the impact module if the user has no main edits

https://gerrit.wikimedia.org/r/863258

Testing note (to check after deployment) - check user Zilant17 on cawiki.

Change 864890 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Use a direct query for checking mainspace edits

https://gerrit.wikimedia.org/r/864890

Change 863088 abandoned by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show the impact module if the user has no main edits

Reason:

per comments

https://gerrit.wikimedia.org/r/863088

Change 864890 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Use a direct query for checking mainspace edits

Reason:

squashed into parent

https://gerrit.wikimedia.org/r/864890

Change 864908 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864908

Change 864909 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864909

Change 864908 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864908

Mentioned in SAL (#wikimedia-operations) [2022-12-06T09:09:27Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:864908|User impact: Do not show impact module if user has no mainspace edits (T324285)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-06T09:11:41Z] <kharlan@deploy1002> kharlan and kharlan: Backport for [[gerrit:864908|User impact: Do not show impact module if user has no mainspace edits (T324285)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-06T09:37:32Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:864908|User impact: Do not show impact module if user has no mainspace edits (T324285)]] (duration: 28m 05s)

Change 863258 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/863258

Change 865074 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/865074

Change 864919 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/864919

Change 865074 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/865074

Change 864919 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: Adjust hasMainspaceEditsCache check

https://gerrit.wikimedia.org/r/864919

Mentioned in SAL (#wikimedia-operations) [2022-12-06T14:11:54Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:864919|NewImpact: Adjust hasMainspaceEditsCache check (T324285)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-06T14:13:49Z] <kharlan@deploy1002> kharlan and kharlan: Backport for [[gerrit:864919|NewImpact: Adjust hasMainspaceEditsCache check (T324285)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-06T14:20:59Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:864919|NewImpact: Adjust hasMainspaceEditsCache check (T324285)]] (duration: 09m 04s)

Change 864909 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] User impact: Do not show impact module if user has no mainspace edits

https://gerrit.wikimedia.org/r/864909

Mentioned in SAL (#wikimedia-operations) [2022-12-06T15:43:30Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:864909|User impact: Do not show impact module if user has no mainspace edits (T324285)]], [[gerrit:865082|Localisation updates from https://translatewiki.net.]], [[gerrit:864911|NewImpact: Show "999+" when we could not count edits/thanks (T324286)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-06T16:02:54Z] <kharlan@deploy1002> kharlan and urbanecm and kharlan: Backport for [[gerrit:864909|User impact: Do not show impact module if user has no mainspace edits (T324285)]], [[gerrit:865082|Localisation updates from https://translatewiki.net.]], [[gerrit:864911|NewImpact: Show "999+" when we could not count edits/thanks (T324286)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.

Mentioned in SAL (#wikimedia-operations) [2022-12-06T16:13:14Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:864909|User impact: Do not show impact module if user has no mainspace edits (T324285)]], [[gerrit:865082|Localisation updates from https://translatewiki.net.]], [[gerrit:864911|NewImpact: Show "999+" when we could not count edits/thanks (T324286)]] (duration: 29m 43s)

Change 865115 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865115

Change 865130 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865130

Change 865131 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865131

Change 865115 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865115

Change 865131 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865131

Change 865130 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.13] Fix UserDatabaseHelper::hasMainspaceEdits()

https://gerrit.wikimedia.org/r/865130

Mentioned in SAL (#wikimedia-operations) [2022-12-06T22:07:11Z] <tgr@deploy1002> Started scap: Backport for [[gerrit:865131|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]], [[gerrit:865130|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-06T22:09:01Z] <tgr@deploy1002> tgr and tgr: Backport for [[gerrit:865131|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]], [[gerrit:865130|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-06T22:26:09Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:865131|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]], [[gerrit:865130|Fix UserDatabaseHelper::hasMainspaceEdits() (T324285)]] (duration: 18m 58s)

Change 865237 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper and add test

https://gerrit.wikimedia.org/r/865237

Change 865237 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix UserDatabaseHelper and add test

https://gerrit.wikimedia.org/r/865237

The last patch - https://gerrit.wikimedia.org/r/865237 - never been deployed.

That patch has been merged but fixed a somewhat narrow issue.

@Tgr - I don't see the null edit state for https://en.wikipedia.org/wiki/Special:Impact/KStoller-WMF and for my test user https://ca.wikipedia.org/wiki/Especial:Impacte/Zilant17. Both users have Thanks, e.g. Special:Log?type=thanks

Just double-checking, are you expecting to see T322850: Add thanks and longest streak scorecards to the unactivated state? That one is not yet merged/deployed.

@Tgr - I don't see the null edit state for https://en.wikipedia.org/wiki/Special:Impact/KStoller-WMF and for my test user https://ca.wikipedia.org/wiki/Especial:Impacte/Zilant17. Both users have Thanks, e.g. Special:Log?type=thanks

Just double-checking, are you expecting to see T322850: Add thanks and longest streak scorecards to the unactivated state? That one is not yet merged/deployed.

Thx, @kostajh - yes, it seems that T322850: Add thanks and longest streak scorecards to the unactivated state will address that. I was just confused with the mockup in the task description. I was expecting it to be done in the scope of this task.