Page MenuHomePhabricator

Query Builder: Adjust footer content and style
Closed, ResolvedPublic

Description

Problem

The Query builder's footer presents a couple of visual inconsistencies (styles, spacing) with that of the similarly structured tool, the Mismatch finder.

The footer also misses a section with links to other quality tools, which would help support their discoverability (see T285744).

Mockups

QueryBuilder-Footer.png (2×3 px, 214 KB)

Link to Figma specifications

Acceptance criteria

Content:

  • The Query Builder's footer provides a list of links to other data quality tools under a new group called ‘More data quality tools’
  • For consistency, the copy of some of the links (see specs) is updated to match that of the Mismatch Finder tool

Style:

  • The links in the Query builder’s footer don't present a default underlined style
  • There's a 2.5rem spacing between the footer and the rest of the page content

Event Timeline

Sarai-WMDE renamed this task from Query builder: Adjust footer content and style to Query Builder: Adjust footer content and style.Dec 2 2022, 6:35 PM

Change 867196 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query-builder@master] Update footer contents

https://gerrit.wikimedia.org/r/867196

The above change implements all the requested changes (I think), except for the spacing change, which I don’t understand and which will probably be easier to discuss in Mattermost. (Edit: I also forgot about the underlined links part.)

Change 867196 merged by jenkins-bot:

[wikidata/query-builder@master] Update footer contents

https://gerrit.wikimedia.org/r/867196

Change 869190 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query-builder@master] Fix QueryBuilder <main> block axis padding

https://gerrit.wikimedia.org/r/869190

Change 869230 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query-builder@master] Use Wikit links in Footer

https://gerrit.wikimedia.org/r/869230

Change 869231 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query-builder@master] Hide underlines for all links in footer

https://gerrit.wikimedia.org/r/869231

Change 869190 merged by jenkins-bot:

[wikidata/query-builder@master] Fix QueryBuilder <main> block axis padding

https://gerrit.wikimedia.org/r/869190

Change 869230 merged by jenkins-bot:

[wikidata/query-builder@master] Use Wikit links in Footer

https://gerrit.wikimedia.org/r/869230

Change 869231 merged by jenkins-bot:

[wikidata/query-builder@master] Hide underlines for all links in footer

https://gerrit.wikimedia.org/r/869231

Change 869243 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: WDQSGuiBuilder):

[wikidata/query-builder/deploy@production] Merging from 49090714f1667afb28fd292ca85eda8ddd88c2fd

https://gerrit.wikimedia.org/r/869243

Change 869243 merged by Lucas Werkmeister (WMDE):

[wikidata/query-builder/deploy@production] Merging from 49090714f1667afb28fd292ca85eda8ddd88c2fd

https://gerrit.wikimedia.org/r/869243

@Sarai-WMDE

Before I close the ticket, I just wanted to double-check the inconsistencies that you mentioned in the ticket.

You have the link spacing on the Query Builder as 2.5rem here and for Mismatch Finder as 2rem on this ticket: T324366

If you are happy having them different, we can close the ticket :)

Thanks so much

All looking great. ACs were all met and the ticket can be closed.

Before I close the ticket, I just wanted to double-check the inconsistencies that you mentioned in the ticket.
You have the link spacing on the Query Builder as 2.5rem here and for Mismatch Finder as 2rem on this ticket: T324366

The 2.5rem spacing mentioned in this ticket refers to the bottom margin of the main container, that separates the content of the page from the footer. This value should be the same in all SPAs (that's currently the case with Query builder and Mismatch finder).
The 2rem value in T324366 refers to the spacing between the link groups within the footer, which is also consistent between both tools. In conclusion, all good.