Fallout from T323542: Forbid new modern code from not targeting mobile?

Testing a revert: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864907

In T324525#8445683, @kostajh wrote:

Presumably affecting many extensions (I came here via a failed GrowthExperiments build.)

Math is affected https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/818294

In T324525#8445709, @kostajh wrote:

Testing a revert: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864907

The revert unbreaks CI, just needs a +2 from someone.

In T324525#8445860, @kostajh wrote:

In T324525#8445709, @kostajh wrote:

Testing a revert: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864907

The revert unbreaks CI, just needs a +2 from someone.

It will need a backport to wmf.13 is as well.

Change 865099 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikibaseLexeme@master] New modern code should target mobile

https://gerrit.wikimedia.org/r/865099

Change 865101 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] jquery.ui.languagesuggester should target mobile

https://gerrit.wikimedia.org/r/865101

The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it

• jquery.ui.languagesuggester targets neither desktop or mobile so defaults to "desktop" (as its not an ES6 module)
• With T323542, wikibase.lexeme.lexemeview as an ES6 module would now target desktop AND mobile
• Since wikibase.lexeme.lexemeview depends on jquery.ui.languagesuggester there is now a mismatch on mobile.

I've been relying on CI heavily for these changes, I'm not sure why this wasn't triggered when the core patch merged so I'll need to investigate this further. Presumably WikibaseLexeme is not including in the core CI build since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864923 is passing validation without https://gerrit.wikimedia.org/r/865101 ?

In T324525#8447407, @Jdlrobson wrote:

I've been relying on CI heavily for these changes, I'm not sure why this wasn't triggered when the core patch merged so I'll need to investigate this further. Presumably WikibaseLexeme is not including in the core CI build since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864923 is passing validation without https://gerrit.wikimedia.org/r/865101 ?

For math, it happens about every quarter that a core or wikibase change breaks the CI tests for math. I still think running daily tests for WMF-deployed extensions would be a great idea, even though I understand that this is not very elegant.

See, for example, https://phabricator.wikimedia.org/T316853 for the last time Math CI tests were broken.

Change 865099 abandoned by Jdlrobson:

[mediawiki/extensions/WikibaseLexeme@master] New modern code should target mobile and desktop

Reason:

I've underestimated the work involved here. Will leave an update on ticket with next steps.

https://gerrit.wikimedia.org/r/865099

Change 865101 abandoned by Jdlrobson:

[mediawiki/extensions/Wikibase@master] jquery.ui.languagesuggester should target mobile

Reason:

I've underestimated the work involved here. Will leave an update on ticket with next steps.

https://gerrit.wikimedia.org/r/865101

Change 865099 restored by Jdlrobson:

[mediawiki/extensions/WikibaseLexeme@master] New modern code should target mobile and desktop

https://gerrit.wikimedia.org/r/865099