Page MenuHomePhabricator

Tooltip not stripped on custom preview types (e.g Math previews)
Open, LowPublicBUG REPORT

Description

In T233099 we made it so that extensions can extend the page previews extension with custom preview types (documented at https://www.mediawiki.org/wiki/Extension:Popups#Extensibility)

One caveat with using custom types is that the tooltip does not get stripped on hover automatically meaning the tooltip and page preview show at the same time:

Screen Shot 2022-12-05 at 5.37.32 PM.png (664×876 px, 136 KB)

Fixing this requires revising the way we allow the user to disable/enable preview types using the settings cog at the bottom of the page. See this comment: https://github.com/wikimedia/mediawiki-extensions-Popups/blob/master/src/changeListeners/linkTitle.js#L50

Event Timeline

Jdlrobson renamed this task from Tooltip not stripped on custom preview types to Tooltip not stripped on custom preview types (e.g Math previews).Mar 21 2023, 5:03 PM
LGoto triaged this task as Low priority.Mar 21 2023, 5:08 PM
LGoto moved this task from Incoming to Groomed on the Web-Team-Backlog board.

@Jdlrobson I didnt realize PagePreviews could be extended in this way! To me, this opens up PagePreviews to be used a generic popup widget, which is why this issue is happening in the first place. Originally PagePreviews would only trigger over links, while this is used on a popup button. I dont know if this was the original intent, but it seems like PagePreviews is now overlapping with OOUI's popup widget, as well as Growth team's Vue Popup component. Perhaps this is worth flagging to the design system team so they are aware when they eventually work on a popup component

Originally PagePreviews would only trigger over links, while this is used on a popup button.

The trigger is still hover, but yes the underlying component is a Popup component, so yes if we had a Codex component, we could use this for indicators as well as previews. One possible use case might be solving T312899 for example.

Perhaps this is worth flagging to the design system team so they are aware when they eventually work on a popup component

I flagged this to @Catrope today.