Page MenuHomePhabricator

Remove button styling from links in Special:Preferences
Closed, DeclinedPublic

Description

Special:Preferences currently has a mix of buttons and linked text to link to other pages. There appears to be no clear reason for this choice one way or the other. We could make this interface much more consistent by simply removing all button styling and presenting these as normal links.

User Story

As a Wikimedia user, I want consistent styling of links in Preferences, so that I'm not confused about which links are more important than others.

Design specs

Screen Shot 2022-06-24 at 11.35.31.png (176×1 px, 40 KB)

Technical information

  • Recently in T317117 we introduced a function that will convert all checkboxes to toggles using JS. We could possibly employ a similar solution here.
  • @ERayfield pointed out that the current HTML markup generated is actually a href styled as a button. This means we may be able to unset the current button styling via css and effectively -undo- the button styling and present the underlying href.
  • Alternatively, we could override button rendering in the defaultPreferences factory and present a link when in mobile view.

Testing and QA steps

  • Log in to a Wikipedia account
  • Navigate to the sidebar and select Settings
  • Turn on Advanced mode
  • Click 'Open preferences' in Settings
  • No buttons should be visible in the User profile or Watchlist tabs

Acceptance Criteria

  • No links are styled as buttons in Special:Preferences

Event Timeline

Special:Preferences currently has a mix of buttons and linked text to link to other pages. There appears to be no clear reason for this choice one way or the other.

This is not quite true. The rule we introduced was is "anything that looks like a user action to set a preference but breaks you out of the form should be a button". Plain links are meant to target _blank so that e.g. the "preview" link for skins is an action that opens a new tab, but the "discussion" link that looks like it takes you out of the form does indeed do so.

We could make this interface much more consistent by simply removing all button styling and presenting these as normal links.

Yes, at a loss of user functionality. I don't think this is a great idea.

@Jdforrester-WMF Ah, very helpful context, thanks for sharing :)

Special:Preferences currently has a mix of buttons and linked text to link to other pages. There appears to be no clear reason for this choice one way or the other.

This is not quite true. The rule we introduced was is "anything that looks like a user action to set a preference but breaks you out of the form should be a button". Plain links are meant to target _blank so that e.g. the "preview" link for skins is an action that opens a new tab, but the "discussion" link that looks like it takes you out of the form does indeed do so.

@AAlhazwani-WMF does this change your thinking around this design choice at all? What I'm hearing here is that buttons signify that there is a setting you can change, but you need to go somewhere else, whereas other plain links are primarily for providing additional context.

Samwalton9-WMF changed the task status from Open to Stalled.Dec 7 2022, 1:11 PM

Declining per the conversation above and our team's changing priorities.