Page MenuHomePhabricator

💥️ Respond with statement-data-invalid-field error for invalid statement fields in PUT and POST endpoints
Closed, ResolvedPublic

Description

  • {field} in the error message in the parent ticket description is the last part of the path
  • InvalidFieldException will need a field and a value parameter
  • StatementValidator will create a ValidationErrorfrom the Exception (exception type determines error code)
  • use case error responses will map the new ValidationError code to the corresponding response format (see parent task description)

Event Timeline

Change 866616 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add field data to InvalidFieldException

https://gerrit.wikimedia.org/r/866616

Change 867139 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Report statement-data-invalid-field errors

https://gerrit.wikimedia.org/r/867139

Change 867528 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Improve invalid field error in PATCH result

https://gerrit.wikimedia.org/r/867528

Change 867567 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Improve invalid field errors, moving the patcher

https://gerrit.wikimedia.org/r/867567

Change 867603 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Improve invalid field errors, removing the patcher

https://gerrit.wikimedia.org/r/867603

Jakob_WMDE renamed this task from 💥️ Respond with statement-data-invalid-field error for invalid statement fields to 💥️ Respond with statement-data-invalid-field error for invalid statement fields in PUT and POST endpoints.Dec 13 2022, 4:23 PM

Change 866616 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add field data to InvalidFieldException

https://gerrit.wikimedia.org/r/866616

Change 867139 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Report statement-data-invalid-field errors

https://gerrit.wikimedia.org/r/867139