Page MenuHomePhabricator
Create Task
Maniphest T324642

Update Pending Transaction Resolver to handle PayPal
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

(at least) two changes are needed in the approvePaymentAndReturnStatus function to make the Resolve action handle the PayPal flow, both in the $approveResult->isSuccessful() block.

  • get donor details from $statusResult->getDonorDetails and when present, add them to the $donationsMessage array.
  • if the pending row says this was a recurring donation, and the $provider object supports creating recurring profiles (see T323962), call $provider->createRecurringPaymentsProfile()

Details

SubjectRepoBranchLines +/-
Initiate recurring profiles in PayPal resolverwikimedia/fundraising/crmmaster+115 -0
Make pending txn resolver work for PayPalwikimedia/fundraising/crmmaster+296 -61
Allow info from status call to overwrite blank keyswikimedia/fundraising/crmmaster+8 -4
Fix PaymentActionNotInitiated status mappingwikimedia/fundraising/SmashPigmaster+56 -5
Rename 'token' params in PayPal API callswikimedia/fundraising/SmashPigmaster+24 -21
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Dec 7 2022, 3:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2022, 3:00 AM
XenoRyet moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Dec 12 2022, 8:48 PM
Dwisehaupt set the point value for this task to 4.Dec 12 2022, 9:26 PM
XenoRyet moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jan 17 2023, 9:06 PM
XenoRyet added a project: Fundraising Sprint Bridge over troubled Wifi.Jan 17 2023, 9:18 PM
Dwisehaupt moved this task from Current Sprint to Sprint +1 on the Fundraising-Backlog board.Jan 24 2023, 8:56 PM
Dwisehaupt removed a project: Fundraising Sprint Bridge over troubled Wifi.
Dwisehaupt subscribed.

Pulling from current sprint to do next sprint.

gerritbot added a comment.Jan 25 2023, 7:33 PM

Change 883651 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Rename 'token' param in getLatestPaymentStatus

https://gerrit.wikimedia.org/r/883651

gerritbot added a project: Patch-For-Review.Jan 25 2023, 7:33 PM
gerritbot added a comment.Jan 27 2023, 2:50 AM

Change 884147 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Fix PaymentActionNotInitiated status mapping

https://gerrit.wikimedia.org/r/884147

gerritbot added a comment.Jan 27 2023, 3:18 AM

Change 884148 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Allow info from status call to overwrite blank keys

https://gerrit.wikimedia.org/r/884148

gerritbot added a comment.Jan 27 2023, 3:18 AM

Change 884149 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Make pending txn resolver work for PayPal

https://gerrit.wikimedia.org/r/884149

gerritbot added a comment.Jan 30 2023, 11:43 PM

Change 883651 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Rename 'token' params in PayPal API calls

https://gerrit.wikimedia.org/r/883651

gerritbot added a comment.Jan 31 2023, 12:32 AM

Change 884147 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Fix PaymentActionNotInitiated status mapping

https://gerrit.wikimedia.org/r/884147

XenoRyet moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jan 31 2023, 9:17 PM
XenoRyet added a project: Fundraising Sprint Can't touch $this.Jan 31 2023, 9:31 PM
AnnWF moved this task from Backlog to Being Reviewed on the Fundraising Sprint Can't touch $this board.Feb 1 2023, 5:07 PM
gerritbot added a comment.Feb 2 2023, 4:58 PM

Change 884148 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Allow info from status call to overwrite blank keys

https://gerrit.wikimedia.org/r/884148

AnnWF moved this task from Being Reviewed to Pending Deployment on the Fundraising Sprint Can't touch $this board.Feb 2 2023, 5:05 PM
gerritbot added a comment.Feb 2 2023, 5:17 PM

Change 884149 merged by Wfan:

[wikimedia/fundraising/crm@master] Make pending txn resolver work for PayPal

https://gerrit.wikimedia.org/r/884149

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 5:30 PM
gerritbot added a comment.Feb 2 2023, 6:33 PM

Change 886129 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Initiate recurring profiles in PayPal resolver

https://gerrit.wikimedia.org/r/886129

gerritbot added a project: Patch-For-Review.Feb 2 2023, 6:33 PM
AnnWF moved this task from Pending Deployment to Doing on the Fundraising Sprint Can't touch $this board.Feb 2 2023, 11:46 PM
AnnWF moved this task from Doing to Being Reviewed on the Fundraising Sprint Can't touch $this board.Feb 3 2023, 5:05 PM
AnnWF moved this task from Being Reviewed to Ready for Review on the Fundraising Sprint Can't touch $this board.Feb 8 2023, 4:35 PM
XenoRyet moved this task from Current Sprint to Sprint +1 on the Fundraising-Backlog board.Feb 14 2023, 7:34 PM
gerritbot added a comment.Feb 17 2023, 11:32 PM

Change 886129 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Initiate recurring profiles in PayPal resolver

https://gerrit.wikimedia.org/r/886129

Maintenance_bot removed a project: Patch-For-Review.Feb 18 2023, 12:10 AM
AKanji-WMF moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Feb 28 2023, 9:21 PM
XenoRyet added a project: Fundraising Sprint Everything I Merge I Merge For You.Feb 28 2023, 9:34 PM
Damilare moved this task from Backlog to Pending Deployment on the Fundraising Sprint Everything I Merge I Merge For You board.Mar 7 2023, 8:37 PM
XenoRyet added a project: Fundraising Sprint Fish HEAD^.Mar 14 2023, 9:15 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Fish HEAD^ board.Mar 14 2023, 9:33 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Fish HEAD^ board.Mar 16 2023, 10:06 PM

I got this working on a single-donation run by deploying the correct credentials to SmashPig config. The old job is disabled and the new job should run every 10 minutes.

There's still some DonationInterface config under the civicrm config that we can clean up

Dwisehaupt closed this task as Resolved.Mar 28 2023, 7:27 PM
Dwisehaupt claimed this task.
Dwisehaupt set Final Story Points to 4.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL