Page MenuHomePhabricator

[Regression ?] The section edit icon on MobileFrontend stops working after posting a reply on production
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Open a talk page on mobile.
  2. Post a reply.
  3. Click on the three dots (...) icon next to the section title.
  4. Click on the button "Edit".

Observe that, nothing happens. The wikitext editor does not open.

IMG-7834.PNG (1×828 px, 961 KB)

It happens on all wikis on production. Checked on MobileFrontend on desktop as well, but didn't see any error on the console.

Event Timeline

There are several problems that combine to cause this:

Change 865729 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix opening the mobile editor after reloading page contents

https://gerrit.wikimedia.org/r/865729

Change 866491 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Reinitialize edit links after page content is reloaded

https://gerrit.wikimedia.org/r/866491

Change 866491 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Reinitialize edit links after page content is reloaded

https://gerrit.wikimedia.org/r/866491

Change 865729 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/DiscussionTools@master] Fix opening the mobile editor after reloading page contents

Reason:

No longer needed

https://gerrit.wikimedia.org/r/865729

Change 866468 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@wmf/1.40.0-wmf.13] Reinitialize edit links after page content is reloaded

https://gerrit.wikimedia.org/r/866468

Change 866468 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.40.0-wmf.13] Reinitialize edit links after page content is reloaded

https://gerrit.wikimedia.org/r/866468

Mentioned in SAL (#wikimedia-operations) [2022-12-08T22:06:25Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:866467|Deemphasize "Learn more about this page" link (T324702)]], [[gerrit:866468|Reinitialize edit links after page content is reloaded (T324686)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-08T22:08:10Z] <samtar@deploy1002> samtar and matmarex: Backport for [[gerrit:866467|Deemphasize "Learn more about this page" link (T324702)]], [[gerrit:866468|Reinitialize edit links after page content is reloaded (T324686)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-08T22:16:31Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:866467|Deemphasize "Learn more about this page" link (T324702)]], [[gerrit:866468|Reinitialize edit links after page content is reloaded (T324686)]] (duration: 10m 06s)