Page MenuHomePhabricator
Create Task
Maniphest T324747

Track performance metrics
Closed, ResolvedPublic
Actions

Description

We don't have good visibility into how long PageTriage internals require. We should add some baseline instrumentation as we work on refactoring.

  • Timing for ArticleCompileProcessor::compileMetadata
  • Timing for ArticleCompileProcessor::compile

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
monitoring: Track timing for compileMetadata methodmediawiki/extensions/PageTriagemaster+9 -0
monitoring: Track timings for ArticleCompileProcess classesmediawiki/extensions/PageTriagemaster+16 -2
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Dec 8 2022, 11:41 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 8 2022, 11:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 8 2022, 11:42 AM

Change 866331 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] monitoring: Track timings for ArticleCompileProcess classes

https://gerrit.wikimedia.org/r/866331

gerritbot added a project: Patch-For-Review.Dec 8 2022, 11:42 AM

Change 866332 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] monitoring: Track timing for compileMetadata method

https://gerrit.wikimedia.org/r/866332

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Dec 8 2022, 11:43 AM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh updated the task description. (Show Details)Dec 8 2022, 11:45 AM
kostajh claimed this task.Dec 12 2022, 11:50 AM
kostajh moved this task from Backlog to Code Review on the PageTriage board.
gerritbot added a comment.Dec 12 2022, 6:31 PM

Change 866331 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] monitoring: Track timings for ArticleCompileProcess classes

https://gerrit.wikimedia.org/r/866331

gerritbot added a comment.Dec 12 2022, 6:31 PM

Change 866332 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] monitoring: Track timing for compileMetadata method

https://gerrit.wikimedia.org/r/866332

TheresNoTime subscribed.EditedDec 12 2022, 6:38 PM

I'll keep an eye on https://graphite-labs.wikimedia.org (for Beta) for the metrics to appear

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 12 2022, 7:01 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 12 2022, 7:30 PM
kostajh updated the task description. (Show Details)Dec 19 2022, 12:46 PM
kostajh added a comment.Dec 19 2022, 12:49 PM

I added panels:

image.png (788×3 px, 188 KB)
/ https://grafana.wikimedia.org/d/GDZR_4IVz/pagetriage-debugging

After looking at the chart, it looks ArticleCompileSnippet could use some improvement, which I filed as T325543: Improve performance of ArticleCompileSnippet.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 9 2023, 5:09 PM
KStoller-WMF closed this task as Resolved.Feb 10 2023, 12:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits