Page MenuHomePhabricator

Track performance metrics
Closed, ResolvedPublic

Description

We don't have good visibility into how long PageTriage internals require. We should add some baseline instrumentation as we work on refactoring.

  • Timing for ArticleCompileProcessor::compileMetadata
  • Timing for ArticleCompileProcessor::compile

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 866331 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] monitoring: Track timings for ArticleCompileProcess classes

https://gerrit.wikimedia.org/r/866331

Change 866332 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] monitoring: Track timing for compileMetadata method

https://gerrit.wikimedia.org/r/866332

kostajh moved this task from Backlog to Code Review on the PageTriage board.

Change 866331 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] monitoring: Track timings for ArticleCompileProcess classes

https://gerrit.wikimedia.org/r/866331

Change 866332 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] monitoring: Track timing for compileMetadata method

https://gerrit.wikimedia.org/r/866332

I'll keep an eye on https://graphite-labs.wikimedia.org (for Beta) for the metrics to appear

I added panels:

image.png (788×3 px, 188 KB)
/ https://grafana.wikimedia.org/d/GDZR_4IVz/pagetriage-debugging

After looking at the chart, it looks ArticleCompileSnippet could use some improvement, which I filed as T325543: Improve performance of ArticleCompileSnippet.