Page MenuHomePhabricator
Create Task
Maniphest T324766

Upgrade WebdriverIO to v8 in core
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
zeljkofilipin changed the task status from In Progress to Open.Nov 24 2023, 4:11 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from High to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Quarter 👔 on the User-zeljkofilipin board.
zeljkofilipin changed the status of subtask T351747: Run Selenium tests locally using Firefox from In Progress to Open.Nov 27 2023, 10:40 AM
Nik.xyz.in unsubscribed.Nov 27 2023, 10:52 AM
zeljkofilipin changed the status of subtask T351747: Run Selenium tests locally using Firefox from Open to In Progress.Nov 27 2023, 3:09 PM
zeljkofilipin changed the status of subtask T351747: Run Selenium tests locally using Firefox from In Progress to Open.Nov 30 2023, 11:57 AM
zeljkofilipin changed the task status from Open to In Progress.Jan 15 2024, 2:51 PM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Quarter 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin added a subtask: T355556: Webdriverio v7 fails locally with node v18 on macos.Jan 23 2024, 3:18 PM
zeljkofilipin changed the status of subtask T355556: Webdriverio v7 fails locally with node v18 on macos from Open to In Progress.
vaughnwalters subscribed.Jan 23 2024, 3:38 PM
zeljkofilipin closed subtask T355556: Webdriverio v7 fails locally with node v18 on macos as Resolved.Jan 29 2024, 3:01 PM
zeljkofilipin added a subscriber: • pwangai.Feb 7 2024, 3:31 PM
gerritbot added a comment.Feb 12 2024, 3:57 PM

Change 1002578 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

gerritbot added a comment.Feb 14 2024, 3:11 PM

Change 866386 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

Reason:

Moved to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/966447

https://gerrit.wikimedia.org/r/866386

gerritbot added a comment.Feb 15 2024, 11:41 AM

Change 866386 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/866386

zeljkofilipin changed the status of subtask T332393: Selenium Jenkins jobs fail after updating @wdio npm packages to v8 from Open to In Progress.Feb 15 2024, 11:57 AM
gerritbot added a comment.Feb 15 2024, 1:46 PM

Change 1003757 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: Fix and update links in comments and documentation

https://gerrit.wikimedia.org/r/1003757

gerritbot added a comment.Feb 16 2024, 7:46 AM

Change 1003757 merged by jenkins-bot:

[mediawiki/core@master] selenium: Fix and update links in comments and documentation

https://gerrit.wikimedia.org/r/1003757

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.19; 2024-02-20); removed MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Feb 16 2024, 9:00 AM
gerritbot added a comment.Feb 16 2024, 12:33 PM

Change 1004089 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Update readme file

https://gerrit.wikimedia.org/r/1004089

gerritbot added a comment.Feb 16 2024, 12:43 PM

Change 1004096 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Update wdio-mediawiki readme file

https://gerrit.wikimedia.org/r/1004096

gerritbot added a comment.Feb 16 2024, 1:30 PM

Change 1004096 merged by jenkins-bot:

[mediawiki/core@master] selenium: Update wdio-mediawiki readme file

https://gerrit.wikimedia.org/r/1004096

gerritbot added a comment.Feb 16 2024, 2:42 PM

Change 1004089 merged by jenkins-bot:

[mediawiki/core@master] selenium: Update readme file

https://gerrit.wikimedia.org/r/1004089

zeljkofilipin closed subtask T332393: Selenium Jenkins jobs fail after updating @wdio npm packages to v8 as Resolved.Feb 19 2024, 12:06 PM
zeljkofilipin changed the task status from In Progress to Open.Feb 19 2024, 5:36 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from High to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Quarter 👔 on the User-zeljkofilipin board.
gerritbot added a comment.Feb 20 2024, 4:59 PM

Change 866386 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

Reason:

https://gerrit.wikimedia.org/r/866386

Peter mentioned this in T358129: Add support for logging in the webdriver.io tests.Feb 21 2024, 5:54 PM
Peter subscribed.Mar 12 2024, 7:17 AM

@zeljkofilipin the first alpha of 9.0 was release earlier today https://github.com/webdriverio/webdriverio/releases/tag/v9.0.0-alpha.0 so I think we should aim for upgrading to 9 instead.

zeljkofilipin added a comment.Apr 4 2024, 11:20 AM

@Peter it's usually way simpler to update one major version at a time. But since we had trouble with v8, maybe giving v9 a try might be a good idea.

zeljkofilipin added a comment.Apr 29 2024, 1:58 PM
In T324766#9622564, @Peter wrote:

@zeljkofilipin the first alpha of 9.0 was release earlier today https://github.com/webdriverio/webdriverio/releases/tag/v9.0.0-alpha.0 so I think we should aim for upgrading to 9 instead.

Tracked in T363704: Upgrade WebdriverIO to v9 in all repositories.

zeljkofilipin changed the task status from Open to In Progress.Apr 30 2024, 2:23 PM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Quarter 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin changed the task status from In Progress to Open.Jun 20 2024, 2:39 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from High to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Quarter 👔 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Quarter 👔 to Backlog 🪒 on the User-zeljkofilipin board.Aug 2 2024, 10:28 AM
gerritbot added a comment.Aug 6 2024, 1:09 PM

Change #966447 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/966447

gerritbot added a comment.Aug 6 2024, 1:10 PM

Change #1002578 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

gerritbot added a comment.Aug 7 2024, 4:04 PM

Change #1002578 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

zeljkofilipin changed the task status from Open to In Progress.Aug 8 2024, 8:27 AM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot added a comment.Aug 8 2024, 12:04 PM

Change #1002578 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

zeljkofilipin changed the task status from In Progress to Open.Aug 8 2024, 12:05 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from High to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Backlog 🪒 on the User-zeljkofilipin board.
gerritbot added a comment.Aug 16 2024, 10:34 AM

Change #1002578 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

gerritbot added a comment.Aug 22 2024, 8:47 AM

Change #1002578 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

gerritbot added a comment.Aug 30 2024, 11:02 AM

Change #1002578 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

gerritbot added a comment.Aug 30 2024, 1:34 PM

Change #1002578 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

gerritbot added a comment.Sep 10 2024, 10:28 AM

Change #1002578 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

zeljkofilipin mentioned this in T376027: Collect relevant data about repositories with Selenium tests.Sep 30 2024, 12:46 PM
gerritbot added a comment.Nov 14 2024, 11:39 AM

Change #1002578 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

Daimona subscribed.Dec 7 2024, 2:27 AM
zeljkofilipin removed a project: User-zeljkofilipin.Jan 13 2025, 1:09 PM
zeljkofilipin added a project: Testing Support.Mar 20 2025, 5:56 PM
zeljkofilipin removed a project: Browser-Tests.Mar 20 2025, 6:00 PM
zeljkofilipin removed a project: MediaWiki-Core-Tests.Mar 24 2025, 6:31 PM
zeljkofilipin added projects: User-zeljkofilipin, Test Platform (kvina).Apr 28 2025, 3:34 PM
zeljkofilipin moved this task from Backlog 🪒 to Sprint 🏃‍➡️ on the User-zeljkofilipin board.
zeljkofilipin changed the task status from Open to In Progress.Apr 29 2025, 9:10 AM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Backlog to In progress on the Test Platform (kvina) board.
zeljkofilipin moved this task from Sprint 🏃‍➡️ to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin mentioned this in T389536: Selenium timeouts can cause the job to remain stuck until the build times out.Apr 29 2025, 12:35 PM
zeljkofilipin removed a subtask: T351747: Run Selenium tests locally using Firefox .Apr 29 2025, 1:09 PM
gerritbot added a comment.Apr 29 2025, 1:21 PM

Change #1002578 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

Daimona mentioned this in T392963: CI is overwhelmed and lots of jobs are failing randomly (2025-04-29).Apr 29 2025, 8:23 PM
thcipriani subscribed.Apr 29 2025, 11:29 PM

Noting that https://gerrit.wikimedia.org/r/1002578 had some problems in CI https://integration.wikimedia.org/ci/job/mediawiki-quibble-selenium-vendor-mysql-php74/25118/console

Notably, it looks like the afterTest hook kept failing, which is also the hook that calls stopVideo in tests/selenium/wdio-mediawiki/wdio-defaults.conf.js.

This matches the symptoms in T392963: CI is overwhelmed and lots of jobs are failing randomly (2025-04-29):

  • beforeTest starts an ffmpeg process to record the framebuffer
  • afterTest sends killall -2 ffmpeg
  • if the afterTest hook is never reached, ffmpeg is never killed, resulting in a ton of processes running—the same number as the number of selenium tests for core.
  • The problem of creating a large number of processes without stopping them was exacerbated by the followup patch to run this in a loop :)
thcipriani added a comment.Apr 29 2025, 11:48 PM

We should figure out how to recreate the ffmpeg/afterTest hook failure/chrome crashing issue and try to debug and fix that ideally before we try this again in CI.

Peter added a comment.Apr 30 2025, 5:36 AM

There is #5545 where afterTest do not run if the tests timeouts. Going through different issues it seems to be fixed in 8.30 something so it seems the fix do not to work for us (latest for us in 8.40). I think we could be more defensive here and add a check in a after or afterHook hook, and just kill ffmpeg there again. Also we could do some try catch/finally in the current block so that if taking a screenshot fails, we try to kill ffmpeg anyway.

Peter mentioned this in T392974: Make sure FFMPEG is killed if screenshot fails.Apr 30 2025, 5:44 AM
Peter added a comment.Apr 30 2025, 5:59 AM

I added https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1139980 to make sure we always try to kill ffmpeg. Then at least we are "safe" in our code.

SDunlap moved this task from kvina to sesa on the Test Platform board.May 12 2025, 1:35 PM
SDunlap edited projects, added Test Platform (sesa); removed Test Platform (kvina).
gerritbot added a comment.May 15 2025, 1:31 PM

Change #1146620 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Pin browser version in CI

https://gerrit.wikimedia.org/r/1146620

gerritbot added a comment.May 21 2025, 2:09 PM

Change #1002578 merged by jenkins-bot:

[mediawiki/core@master] selenium: Upgrade WebdriverIO to v8

https://gerrit.wikimedia.org/r/1002578

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 21 2025, 3:00 PM
gerritbot added a comment.May 21 2025, 5:17 PM

Change #1146620 merged by jenkins-bot:

[mediawiki/core@master] selenium: Pin browser version in CI

https://gerrit.wikimedia.org/r/1146620

zeljkofilipin closed this task as Resolved.May 26 2025, 2:30 PM
WMDE-Fisch awarded a token.May 26 2025, 5:01 PM
zeljkofilipin mentioned this in T402379: Clean up in wdio-defaults.conf.js.Aug 20 2025, 9:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits