Page MenuHomePhabricator

Revise appearance of section edit links when visual enhancements are enabled
Open, Needs TriagePublic

Description

T255560 Introduced a new visual appearance for the Reply buttons that appear on desktop talk pages for people who have the Show discussion activity setting enabled within Special:Preferences.

This task involves the work of evolving the appearance of the section edit links ([ edit ], [ edit | edit source ]) so that they match the appearance of the unbracketed Reply buttons.


Thank you to @Jonesey95 for pointing out the need for this task .

Event Timeline

Maybe this is already in scope, but please remember to include the additional edit link provided by the gadget called (on en.WP) "Add an [edit] link for the lead section of a page".

I don't feel too strongly about this, but I thought it was an intentional decision: both to de-emphasize these links for new users and encourage them to use "Reply" instead of editing comments by hand, and to give established users who like using the full editor the comfort of not having to change their habits even as we change the rest of the interface.

My understanding is that the Reply, Edit, and Subscribe links are being brought into compliance with the MediaWiki style guide at https://design.wikimedia.org/style-guide/components/buttons.html#type-quiet-buttons. If you have a style guide, you should either follow it, change it, or get rid of it. If you have one and don't follow it, it is useless.

Well, it's nice to have guidelines, and when all else is equal we should choose a design that follows them rather than one that doesn't, but when we have a reason to do something different, we shouldn't abandon all thought in the name of consistency. (I'd be okay with changing things in this case, just explaining my principles :) )