Page MenuHomePhabricator

Result view selector starts out with “eye” icon and no label, instead of table icon + label, if no default view specified in query
Closed, ResolvedPublic

Authored By
Lucas_Werkmeister_WMDE
Dec 9 2022, 12:33 PM
Referenced Files
F35847815: image.png
Dec 9 2022, 12:33 PM
F35847812: image.png
Dec 9 2022, 12:33 PM
F35847810: image.png
Dec 9 2022, 12:33 PM
F35847808: image.png
Dec 9 2022, 12:33 PM

Description

In the WDQS GUI, if you run a query without a #defaultView: comment (example), the result view button looks like this:

image.png (188×274 px, 4 KB)

As soon as you select any result view (even if you just select “table” again), it shows that result view’s name and icon:

image.png (188×274 px, 5 KB)image.png (188×274 px, 5 KB)

Likewise if the query contains a #defaultView: comment, even if it’s #defaultView:Table (link):

image.png (188×274 px, 5 KB)

Event Timeline

I noticed this while working on T311594: Wikidata Query Service UI: Remove maps download option that is not actually working (_setSelectedDisplayType() is not called in one scenario). I assume it’s just an oversight, and I’m including a fix in my change for that task; CC @Lydia_Pintscher and @Sarai-WMDE, though, in case this seems like something we should keep.

Change 866583 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query/gui@master] Disable SVG downloads for unsupported result views

https://gerrit.wikimedia.org/r/866583

Good catch! The fix seems appropriate 👍🏻

Change 866583 merged by jenkins-bot:

[wikidata/query/gui@master] Disable SVG downloads for unsupported result views

https://gerrit.wikimedia.org/r/866583

Change 867212 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder):

[wikidata/query/gui-deploy@production] Merging from 77db0250a5222086941bbb1d90a44ddc489746b2

https://gerrit.wikimedia.org/r/867212

Change 867212 merged by Lucas Werkmeister (WMDE):

[wikidata/query/gui-deploy@production] Merging from 77db0250a5222086941bbb1d90a44ddc489746b2

https://gerrit.wikimedia.org/r/867212