Wrong headings are bolded in the ToC
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	sgrabarczuk
	Dec 9 2022, 7:52 PM

Description

Steps to replicate the issue (include links if applicable):

Go to this section
What happens The heading for "Analyse by Dušan Kreheľ: To have Vector as default skin Wikipedies from 2022-10-03?" is bolded
So click that heading in the ToC and scroll a bit up to the section above
What happens The heading of first section below the Beginning link ("Too narrow (again)") is bolded

What should have happened instead?:
The bolded heading in the ToC should match the section on the screen

Other information (browser name/version, screenshots, etc.): both the newest Firefox and Chrome

Details

	Subject	Repo	Branch	Lines +/-
	Mark active sections even when their headings are in wrapper elements	mediawiki/skins/Vector	wmf/1.40.0-wmf.14	+1 -1
	Mark active sections even when their headings are in wrapper elements	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T325819: pl.wiki: editcontentmodel for interface-admin
T318044: Active section is determined incorrectly when real active section is inside a wrapper
T325115: Links to sections on talk pages with collapsible header templates are unreliable (due to templates collapsing late and moving the page content)
T316037: Current section highlighting in TOC doesn't work after update
Mentioned Here: T325819: pl.wiki: editcontentmodel for interface-admin
T325115: Links to sections on talk pages with collapsible header templates are unreliable (due to templates collapsing late and moving the page content)
T314714: Metadata and buttons should be inserted after a heading, not inside of it
T316037: Current section highlighting in TOC doesn't work after update
T318044: Active section is determined incorrectly when real active section is inside a wrapper

Event Timeline

sgrabarczuk created this task.Dec 9 2022, 7:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2022, 7:52 PM

Jdlrobson added projects: DiscussionTools, Web-Team-Backlog.Dec 10 2022, 1:16 AM

Maybe this is a duplicate of T318044, the DiscussionTools extension would add a wrapper to h2 elements.

Jdlrobson moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Dec 13 2022, 5:11 PM

Jdlrobson mentioned this in T316037: Current section highlighting in TOC doesn't work after update.

ovasileva triaged this task as Medium priority.Dec 13 2022, 5:25 PM

ovasileva moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Dec 13 2022, 5:31 PM

• ppelberg added a subscriber: • ppelberg.Dec 13 2022, 9:48 PM

• alexhollender_WMF awarded a token.Dec 13 2022, 9:50 PM

• alexhollender_WMF added a subscriber: • alexhollender_WMF.

@alexhollender_WMF also identified an issue where if you navigate directly to a section within a talk page (e.g. link 1) the wrong section within the ToC is highlighted (Actual: Etymology-Literature vs. Expected: please unclutter the montage).

Question: do we think the patch(es) that will fix the issue this ticket currently describes might also cover the issue I described above?

In T324869#8464892, @ppelberg wrote:

@alexhollender_WMF also identified an issue where if you navigate directly to a section within a talk page (e.g. link 1) the wrong section within the ToC is highlighted (Actual: Etymology-Literature vs. Expected: please unclutter the montage).

Question: do we think the patch(es) that will fix the issue this ticket currently describes might also cover the issue I described above?

This looks unrelated. Moved to T325115

Change 867725 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Mark active sections even when their headings are in wrapper elements

https://gerrit.wikimedia.org/r/867725

gerritbot added a project: Patch-For-Review.Dec 13 2022, 10:50 PM

matmarex claimed this task.Dec 13 2022, 10:50 PM

matmarex added a project: Editing-team (Kanban Board).

This bug affects discussion pages on projects where we already deployed the fix for T314714 – including MediaWiki.org (as reported here) and Polish Wikipedia (as reported at T316037#8463134), but not English Wikipedia.

matmarex mentioned this in T325115: Links to sections on talk pages with collapsible header templates are unreliable (due to templates collapsing late and moving the page content).Dec 13 2022, 10:59 PM

Also, @Func is correct that this is basically the same issue as T318044 (except that it's caused by markup generated by our code, rather than added in wikitext), so you'll also see a similar problem on pages that have headings wrapped in fancy markup on any project, including English Wikipedia – for example https://en.wikipedia.org/wiki/Wikipedia:Articles_for_deletion/Log/2022_December_1?useskin=vector-2022.

matmarex mentioned this in T318044: Active section is determined incorrectly when real active section is inside a wrapper.Dec 13 2022, 11:12 PM

Moving this to Blocked while we await code review from the Web Team. cc @Jdlrobson

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Dec 15 2022, 4:40 PM

Change 867725 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Mark active sections even when their headings are in wrapper elements

https://gerrit.wikimedia.org/r/867725

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 16 2022, 1:01 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2022, 1:30 AM

Nux added a subscriber: Nux.Dec 17 2022, 9:03 PM

• ppelberg added a project: Editing QA.Dec 19 2022, 6:25 PM

• ppelberg moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.

EAkinloose edited projects, added Verified; removed Editing QA.Jan 4 2023, 1:03 AM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

Change 874884 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.14] Mark active sections even when their headings are in wrapper elements

https://gerrit.wikimedia.org/r/874884

gerritbot added a project: Patch-For-Review.Jan 4 2023, 1:55 PM

I'm backporting this, because I forgot that it wasn't fixed in production yet, and yesterday I deployed a config change that accidentally spread this issue to additional wikis (T314714). Sorry about that.

Change 874884 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.14] Mark active sections even when their headings are in wrapper elements

https://gerrit.wikimedia.org/r/874884

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:18:04Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:870978|plwiki: Add editcontentmodel to interface-admin (T325819)]], [[gerrit:874884|Mark active sections even when their headings are in wrapper elements (T318044 T324869)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:19:53Z] <urbanecm@deploy1002> urbanecm and stang and matmarex: Backport for [[gerrit:870978|plwiki: Add editcontentmodel to interface-admin (T325819)]], [[gerrit:874884|Mark active sections even when their headings are in wrapper elements (T318044 T324869)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:27:36Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:870978|plwiki: Add editcontentmodel to interface-admin (T325819)]], [[gerrit:874884|Mark active sections even when their headings are in wrapper elements (T318044 T324869)]] (duration: 09m 32s)