Change 866661 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Instrument pinned and unpinned links differently

https://gerrit.wikimedia.org/r/866661

This is what I recommend doing here:

• Updating the pinning functionality to operate on PinnedContainer component.
• Using JS to set the correct. I've used "-pinned" and "-unpinned" in the example so we can distinguish our new events from cached HTML.

Note: I didn't check if events run twice. Presumably they won't since the same event handler runs on both and data-event-name is usually preferred.

Feel free to take over my patch in my absence :)

Change 866661 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Instrument pinned and unpinned links differently

Reason:

Just demonstrating how this could work. Feel free to fork this to a new patch with yourself as the author if you want to work off of my code :)

https://gerrit.wikimedia.org/r/866661

Change 869266 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/WikimediaEvents@master] Distinguish between pinned/unpinned elements in desktopWebUIActions

https://gerrit.wikimedia.org/r/869266

@Jdlrobson I've considered the suggestion above and taken a slightly different approach.

Modifying all DOM elements during pinning/unpinning event seemed a little risky, given that gadgets can insert elements in the menu, and performance wise, it also seemed like a lot of DOM operations for functionality that's only meant for WMF analytics. For these reasons, I placed this logic in the Wikimedia Events repo instead.

The approach is basically: on click, find the parent pinnable header, and if it exists, use that to modify the event data. The pinnable header contains the pinned/unpinned state as well as a "feature-name" attribute. I think it would be useful to include that feature-name attribute in the event data as well.

So for example, instead of ca-protect the event data would now be ca-protect.vector-page-tools.pinned

Just want to confirm that this would be useful?

@Jdrewniak yes this seems like a lot better approach than mine. I have a few questions on the Gerrit patch.

Change 875997 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Log events for pinnable header button

https://gerrit.wikimedia.org/r/875997

Change 869266 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Distinguish between pinned/unpinned elements in desktopWebUIActions

https://gerrit.wikimedia.org/r/869266

Just https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/875997/ remaining and we can move this to QA :)

Change 875997 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Log events for pinnable header button

https://gerrit.wikimedia.org/r/875997

LGTM.

"❓ Switch to Old Version" > we track that by looking at preferences changes (since some people may follow the link but not act on it)

event says sitesupport, I'm assuming this is because it's beta

That's fine. IT will be the same in production. It's unintuitive but as long as it's unique that's good.