Deprecated: Creation of dynamic property MWCallbackStream::$stream is deprecated in MWCallbackStream.php on line 42
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Dec 10 2022, 6:56 PM

Project Tags

Referenced Files

None

Subscribers

Description

Deprecated: Creation of dynamic property MWCallbackStream::$stream is deprecated in /var/www/wiki/mediawiki/core/includes/http/MWCallbackStream.php on line 42

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
MWCallbackStream: Add explicit $stream property	Reedy	mediawiki/core	REL1_39	+3 -0
MWCallbackStream: Add explicit $stream property	Reedy	mediawiki/core	REL1_38	+3 -0
MWCallbackStream: Add explicit $stream property	Reedy	mediawiki/core	REL1_35	+3 -0
MWCallbackStream: Add explicit $stream property	Reedy	mediawiki/core	master	+3 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T314099 PHP 8.2: Dynamic property creation is deprecated
		Resolved		Reedy	T324895 Deprecated: Creation of dynamic property MWCallbackStream::$stream is deprecated in MWCallbackStream.php on line 42

Event Timeline

Reedy created this task.Dec 10 2022, 6:56 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.2 support board.Dec 10 2022, 9:38 PM

* @property StreamInterface $stream Defined in StreamDecoratorTrait via `@property`, not read
*  by phan

But StreamDecoratorTrait also does not declare that property - https://github.com/guzzle/psr7/blob/67c26b443f348a51926030c83481b85718457d3d/src/StreamDecoratorTrait.php#L12

Does the trait assume the use class declares it? Or is this a upstream issue?

This is a problem for VE with deprecation warnings turned on. The resulting JSON is invalid.

In T324895#8459009, @Umherirrender wrote:

But StreamDecoratorTrait also does not declare that property - https://github.com/guzzle/psr7/blob/67c26b443f348a51926030c83481b85718457d3d/src/StreamDecoratorTrait.php#L12

Does the trait assume the use class declares it? Or is this a upstream issue?

Guess we could ask upstream...

In T324895#8459009, @Umherirrender wrote:

But StreamDecoratorTrait also does not declare that property - https://github.com/guzzle/psr7/blob/67c26b443f348a51926030c83481b85718457d3d/src/StreamDecoratorTrait.php#L12

Does the trait assume the use class declares it? Or is this a upstream issue?

https://github.com/guzzle/psr7/blob/b4719a1/src/DroppingStream.php#L15-L21

Looks like in their own usages of StreamDecoratorTrait they declare it...

Added a PR to "fix" their docs - https://github.com/guzzle/psr7/pull/545

Change 872474 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] MWCallbackStream: Add explicit $stream property

https://gerrit.wikimedia.org/r/872474

gerritbot added a project: Patch-For-Review.Dec 27 2022, 5:03 PM

Change 872474 merged by jenkins-bot:

[mediawiki/core@master] MWCallbackStream: Add explicit $stream property

https://gerrit.wikimedia.org/r/872474

Change 871274 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] MWCallbackStream: Add explicit $stream property