Page MenuHomePhabricator
Create Task
Maniphest T324896

Deprecated: Creation of dynamic property in oojs/oojs-ui
Closed, ResolvedPublic
Actions

Description

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$checkIcon is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 37

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$indeterminate is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 92

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\PanelLayout::$preserveContent is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/PanelLayout.php on line 20

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
php: Declare all class propertiesoojs/uiv0.44+58 -1
Tag: Allow dynamic properties on PHP 8.2oojs/uimaster+1 -0
php: Declare all class propertiesoojs/uimaster+58 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Dec 10 2022, 6:57 PM

And some more...

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$checkIcon is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 37

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$indeterminate is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 92

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$checkIcon is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 37

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$indeterminate is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 92

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$checkIcon is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 37

Deprecated: Creation of dynamic property OOUI\CheckboxInputWidget::$indeterminate is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php on line 92

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property OOUI\FieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 123

Deprecated: Creation of dynamic property HTMLFormFieldLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldLayout.php on line 124

Deprecated: Creation of dynamic property OOUI\FieldsetLayout::$helpText is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldsetLayout.php on line 41

Deprecated: Creation of dynamic property OOUI\FieldsetLayout::$helpInline is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/FieldsetLayout.php on line 42

Deprecated: Creation of dynamic property OOUI\PanelLayout::$preserveContent is deprecated in /var/www/wiki/mediawiki/core/vendor/oojs/oojs-ui/php/layouts/PanelLayout.php on line 20
gerritbot added a comment.Dec 10 2022, 7:06 PM

Change 866482 had a related patch set uploaded (by Reedy; author: Reedy):

[oojs/ui@master] Tag: Allow dynamic properties on PHP 8.2

https://gerrit.wikimedia.org/r/866482

gerritbot added a project: Patch-For-Review.Dec 10 2022, 7:06 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.2 support board.Dec 10 2022, 9:38 PM
Umherirrender subscribed.Dec 11 2022, 1:34 AM

We should fix the suppressed phan issues instead of allowing the dynamic properties.
At least for the properties used in this library.

.phan/config.php
// @todo remove
$cfg['suppress_issue_types'][] = 'PhanUndeclaredProperty';
$cfg['suppress_issue_types'][] = 'PhanUndeclaredMethod';
gerritbot added a comment.Dec 11 2022, 1:51 AM

Change 866724 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[oojs/ui@master] php: Declare all class properties

https://gerrit.wikimedia.org/r/866724

gerritbot added a comment.Dec 12 2022, 2:35 PM

Change 866724 merged by jenkins-bot:

[oojs/ui@master] php: Declare all class properties

https://gerrit.wikimedia.org/r/866724

gerritbot added a comment.Dec 12 2022, 4:44 PM

Change 866482 abandoned by Reedy:

[oojs/ui@master] Tag: Allow dynamic properties on PHP 8.2

Reason:

https://gerrit.wikimedia.org/r/c/oojs/ui/+/866724

https://gerrit.wikimedia.org/r/866482

gerritbot added a comment.Dec 12 2022, 4:46 PM

Change 866704 had a related patch set uploaded (by Reedy; author: Umherirrender):

[oojs/ui@v0.44] php: Declare all class properties

https://gerrit.wikimedia.org/r/866704

gerritbot added a comment.Dec 12 2022, 5:08 PM

Change 866704 merged by jenkins-bot:

[oojs/ui@v0.44] php: Declare all class properties

https://gerrit.wikimedia.org/r/866704

Reedy closed this task as Resolved.Dec 12 2022, 5:44 PM
Reedy assigned this task to Umherirrender.
Reedy removed a project: Patch-For-Review.
Reedy mentioned this in T325000: Release v0.44.4.
Reedy mentioned this in T325954: OOUI release v0.46.1.Dec 27 2022, 3:01 AM
Reedy added a parent task: T325954: OOUI release v0.46.1.
Reedy added a parent task: T325000: Release v0.44.4.Jan 4 2023, 7:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits