Deprecated: Creation of dynamic property Wikimedia\Parsoid\DOM\Document::$body is deprecated in /var/www/wiki/mediawiki/core/vendor/wikimedia/parsoid/src/Utils/DOMCompat.php on line 88
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T314099 PHP 8.2: Dynamic property creation is deprecated | |||
Resolved | Reedy | T324902 Deprecated: Creation of dynamic property Wikimedia\Parsoid\DOM\Document::$body is deprecated in DOMCompat.php on line 88 |
Event Timeline
// Use an undeclared dynamic property as a cache. // WARNING: this will not be updated if (for some reason) the // document body changes. if ( isset( $document->body ) ) { return $document->body; }
Can we just add a $body property to Wikimedia\Parsoid\DOM\Document and then change the semantics around isset to be if ( $document->body !== null ) { or similar?
Change 867652 had a related patch set uploaded (by Reedy; author: Reedy):
[mediawiki/services/parsoid@master] DOM\Document: Add body parameter for caching
Change 867652 merged by jenkins-bot:
[mediawiki/services/parsoid@master] DOM\Document: Add body parameter for caching
Change 868050 had a related patch set uploaded (by Reedy; author: Reedy):
[mediawiki/services/parsoid@REL1_39] DOM\Document: Add body parameter for caching
Change 868050 merged by jenkins-bot:
[mediawiki/services/parsoid@REL1_39] DOM\Document: Add body parameter for caching
Change 877256 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/vendor@master] Bump parsoid to 0.17.0-a10
Change 877256 merged by jenkins-bot:
[mediawiki/vendor@master] Bump parsoid to 0.17.0-a10