Page MenuHomePhabricator

Set expensive parser flag for maps expansion during parse time
Closed, ResolvedPublic

Description

Our new, experimental approach of expanding geoshapes at page parse time can be slow, since it makes requests from external services. This should be tracked during parse, and fall back to simpler logic when appropriate.

  • Increment expensive function counter when expanding each geoshape.
  • When expensive function limit has been exceeded, geoshape expansion should be skipped and we fall back to leaving the inline ExternalData link in mapdata.

Event Timeline

lilients_WMDE renamed this task from Set "expensive" parser flag. to Set expensive parser flag for maps expansion during parse time.Dec 12 2022, 9:53 PM

Change 869757 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] [WIP] Respect and increment expensive function count

https://gerrit.wikimedia.org/r/869757

Change 869757 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Respect and increment expensive function count

https://gerrit.wikimedia.org/r/869757