Page MenuHomePhabricator

Create jQuery replacements for injectSpinner and removeSpinner
Closed, ResolvedPublic

Description

Author: john

Description:
Right now there is no jQuery compatible replacement for /(inject|remove)Spinner/

Do it right now!


Version: unspecified
Severity: enhancement

Details

Reference
bz30499

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:49 PM
bzimport set Reference to bz30499.

john wrote:

Spinner plugin

Add a spinner after an element

$( '#mw-abusefilter-syntaxcheck' ).injectSpinner( 'abusefilter-syntaxcheck' );

Create a spinner element and return it

$.createSpinner( 'abusefilter-syntaxcheck' );

Remove a spinner element

$.removeSpinner( 'abusefilter-syntaxcheck' );

Attached:

So FYI there are already jquery spinner plugins in MwEmbed and UploadWizard.

Can we just pick one? :)

john wrote:

Applied in r95445

To be honest I did look at those 2 implementations but I didn't feel they were general enough, and were both sort of odd. This is a direct replacement for injectSpinner found in wikibits.js, and will aid in developers who are making a transition from old style JS to use jQuery.