Page MenuHomePhabricator

Include EU Registered Country in the canonical country database
Closed, ResolvedPublic3 Estimated Story Points

Description

This task is to include the EU country membership into the canonical_data.countries hive table.

As part of the task document the canonical dataset fields: https://datahub.wikimedia.org/dataset/urn:li:dataset:(urn:li:dataPlatform:hive,canonical_data.countries,PROD)/Schema?is_lineage_mode=false&schemaFilter=

Requirements:

  • Communication with the Product-Analytics team
  • Coding
  • Documenting

Details

Due Date
Jan 13 2023, 6:00 AM

Event Timeline

JAllemandou renamed this task from Include EU Registered Country in the maxmind country import to Include EU Registered Country in the canonical country database.Dec 12 2022, 5:50 PM
JArguello-WMF set Due Date to Jan 13 2023, 6:00 AM.
JArguello-WMF set the point value for this task to 3.
mforns updated Other Assignee, removed: mforns.
nshahquinn-wmf added a subscriber: mforns.

The PR to review is here: https://github.com/wikimedia-research/canonical-data/pull/3.

It should be a very straightforward review. We'll discuss who should do this at our team meeting tomorrow.

mpopov moved this task from Blocked to Doing on the Product-Analytics (Kanban) board.
mpopov subscribed.

Neil will do the necessary fixes

Oh, I can do that, @mpopov! I was looking into that today.
If that's OK to you.

nshahquinn-wmf moved this task from Doing to Blocked on the Product-Analytics (Kanban) board.

@mforns oh sure! I thought I might as well do it since you seemed busy and it would take me 5 mins, but I'm fine either way 😊

If you're doing it, I just added a readme for the dataset; could you rebase and then add the new field there? That would be a good place to note the issue with Outermost Regions and Overseas Countries and Territories.

@nshahquinn-wmf I saw you merged the changes, thank you! :-)
Please, would it be possible for you to run the notebook and update the table?
I had difficulties last time, because the table is owned by Product Analytics user.
I broke the table and had to call for help to restore it :S

nshahquinn-wmf added a subscriber: EChetty.

@mforns of course! I just deployed it.

Leaving this open in case @EChetty needs to sign off.