Page MenuHomePhabricator
Create Task
Maniphest T325007

[regression,subtask] page preview doesn't display when mouse hovers over wikilinked text that has italic and / or span (and perhaps other html) markup
Closed, ResolvedPublicBUG REPORT
Actions

Description

What happens?: The template {{USS|Will Rogers|SSBN-659}} creates this wiki-markup:

  • [[USS&#32;Will Rogers&#32;(SSBN-659)|USS&nbsp;''Will Rogers''&nbsp;<span class="nowrap">(SSBN-659)</span>]]

Media wiki translates that to this html markup:

  • <a href="/wiki/USS_Will_Rogers_(SSBN-659)" title="USS Will Rogers (SSBN-659)">USS&#160;<i>Will Rogers</i>&#160;<span class="nowrap">(SSBN-659)</span></a>

At en.wiki using desktop display, hovering the mouse pointer over 'USS' in the rendered link produces a page preview. Hovering the mouse pointer over 'Will Rogers' produces a simple tooltip. Hovering the mouse pointer over '(SSBN-659)' produces a simple tooltip. Hovering the mouse pointer over the whitespace between 'Will Rogers' and '(SSBN-659)' produces a page preview.

What should have happened instead?: Page previews should provide a page-preview tooltip regardless of where on the rendered wikilink the mouse pointer hovers
Other information (browser name/version, screenshots, etc.): For me, win 10 chrome current version; reported to be the same for win 10 firefox. Initially discussed at en:WP:VPT

QA steps

In beta cluster, hovering over the italized portion of the link should trigger a preview:
https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson/T325007

In production hover over the italic portion of this link:
https://en.wikipedia.org/wiki/User:Jdlrobson/T325007

Exploratory testing is important as part of this task. Are there any links not generating a preview that should be?

QA Results - Beta

ACStatusDetails
1✅T325007#8464113

QA Results - Prod

ACStatusDetails
1✅T325007#8468184

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Popupswmf/1.40.0-wmf.13+39 -18Child elements also trigger previews
mediawiki/extensions/Popupsmaster+39 -18Child elements also trigger previews
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trappist_the_monk created this task.Dec 12 2022, 7:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2022, 7:20 PM
• Jdlrobson added a project: Regression.Dec 12 2022, 7:32 PM
• Jdlrobson added subscribers: ovasileva, • Jdlrobson.

@ovasileva seems like a regression caused by T233099 unfortunately :-(

• Jdlrobson added a parent task: T233099: [For visibility] Page previews should be externally extendable.Dec 12 2022, 7:32 PM
• Jdlrobson updated the task description. (Show Details)Dec 12 2022, 7:40 PM
gerritbot added a comment.Dec 12 2022, 8:09 PM

Change 867271 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Child elements also trigger previews

https://gerrit.wikimedia.org/r/867271

gerritbot added a project: Patch-For-Review.Dec 12 2022, 8:09 PM
ovasileva triaged this task as Unbreak Now! priority.Dec 12 2022, 10:23 PM
• Jdlrobson renamed this task from page preview doesn't display when mouse hovers over wikilinked text that has italic and / or span (and perhaps other html) markup to [regression,subtask] page preview doesn't display when mouse hovers over wikilinked text that has italic and / or span (and perhaps other html) markup .Dec 12 2022, 10:45 PM
• Jdlrobson added a project: Readers-Web-Backlog (Kanbanana-2022-23-Q2).
• Jdlrobson moved this task from Needs Analysis to Code Review on the Readers-Web-Backlog (Kanbanana-2022-23-Q2) board.
• nray claimed this task.Dec 13 2022, 12:13 AM
gerritbot added a comment.Dec 13 2022, 12:57 AM

Change 867271 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Child elements also trigger previews

https://gerrit.wikimedia.org/r/867271

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 13 2022, 1:00 AM
gerritbot added a comment.Dec 13 2022, 1:02 AM

Change 867233 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.40.0-wmf.13] Child elements also trigger previews

https://gerrit.wikimedia.org/r/867233

• Jdlrobson added a comment.Dec 13 2022, 1:04 AM

@ovasileva this should ride this week's train. We should probably backport it before then, ideally after doing some QA.
I can't backport it tomorrow due to a meeting conflict. Feel free to get someone else to do that.
If not I can probably backport this on Wednesday. Please let me know how you want us to proceed!

• Jdlrobson reassigned this task from • nray to Edtadros.Dec 13 2022, 1:04 AM
• Jdlrobson moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-2022-23-Q2) board.
• Jdlrobson updated the task description. (Show Details)
• Jdlrobson added a subscriber: • nray.
ovasileva reassigned this task from Edtadros to Jdrewniak.Dec 13 2022, 4:26 PM
ovasileva added subscribers: Jdrewniak, Edtadros.

@Jdrewniak will backport later today. Moving to doing.

Edtadros moved this task from QA to QA in Prod on the Readers-Web-Backlog (Kanbanana-2022-23-Q2) board.EditedDec 13 2022, 5:33 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome, Safari, Edge, Firefox, Opera
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: In beta cluster, hovering over the italicized portion of the link should trigger a preview:
https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson/T325007

Screenshot 2022-12-13 at 9.16.05 AM.png (655×1 px, 128 KB)

TheresNoTime added a subscriber: TheresNoTime.Dec 13 2022, 8:12 PM
gerritbot added a comment.Dec 13 2022, 9:07 PM

Change 867233 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.40.0-wmf.13] Child elements also trigger previews

https://gerrit.wikimedia.org/r/867233

Stashbot added a comment.Dec 13 2022, 9:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-13T21:08:06Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:867233|Child elements also trigger previews (T325007)]]

Stashbot added a comment.Dec 13 2022, 9:09 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-13T21:09:53Z] <samtar@deploy1002> samtar and jdlrobson: Backport for [[gerrit:867233|Child elements also trigger previews (T325007)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Dec 13 2022, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-13T21:17:44Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:867233|Child elements also trigger previews (T325007)]] (duration: 09m 38s)

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2022, 9:30 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.13; 2022-12-05); removed MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 13 2022, 10:01 PM
• Jdlrobson moved this task from QA in Prod to Needs More Work on the Readers-Web-Backlog (Kanbanana-2022-23-Q2) board.Dec 13 2022, 10:11 PM
• Jdlrobson mentioned this in T325113: [subtask] SyntaxError: Element.closest: '#mw-content-text a[href][title]:not(.extiw, .mw-selflink, .image, .new, .internal, .external, .mw-cite-backlink a, .oo-ui-buttonedElement-button, .ve-ce-surface a, .cancelLink a), #mw-content-text .reference a[ href*="#" ]' is not a valid selector.
• Jdlrobson reassigned this task from Jdrewniak to Edtadros.Dec 13 2022, 11:11 PM
• Jdlrobson lowered the priority of this task from Unbreak Now! to High.
• Jdlrobson moved this task from Needs More Work to QA on the Readers-Web-Backlog (Kanbanana-2022-23-Q2) board.
• Jdlrobson moved this task from QA to QA in Prod on the Readers-Web-Backlog (Kanbanana-2022-23-Q2) board.

The fix for this is now in production. Thanks @Jdrewniak

Edtadros reassigned this task from Edtadros to ovasileva.EditedDec 14 2022, 5:12 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2022-23-Q2) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome, Safari, Edge, Firefox, Opera
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: In enwiki, hovering over the italicized portion of the link should trigger a preview:
https://en.wikipedia.org/wiki/User:Jdlrobson/T325007

Screen Recording 2022-12-13 at 3.13.30 PM.mov.gif (794×1 px, 491 KB)

Edtadros updated the task description. (Show Details)Dec 15 2022, 5:43 PM
ovasileva closed this task as Resolved.Dec 16 2022, 3:54 PM
phuedx added a subtask: T325113: [subtask] SyntaxError: Element.closest: '#mw-content-text a[href][title]:not(.extiw, .mw-selflink, .image, .new, .internal, .external, .mw-cite-backlink a, .oo-ui-buttonedElement-button, .ve-ce-surface a, .cancelLink a), #mw-content-text .reference a[ href*="#" ]' is not a valid selector.Jan 4 2023, 10:08 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL