Page MenuHomePhabricator

Improper focus when closing Language menu
Closed, ResolvedPublic

Description

Description

Created as a result of AFB accessibility testing results T323634

Focus is sent to top of screen when closing menu, when the focus should be programmatically placed back on the menu button.
High priority, 2.4.3 Focus Order (Level A)

Steps to reproduce

  1. Go to https://en.wikipedia.org/wiki/Gualaca?useskin=vector-2022
  2. Open the language selector
  3. Press escape to close the language selector
  4. Press tab again

Observation

The focus goes to the top of the page.

Event Timeline

Some additional info after merging T339818: ULS should return focus to element it was triggered by if it's closed with Esc:

Also, ULS search field does not have a proper label, which also is an accessibility violation that should be fixed. It does have a placeholder, but that is not a proper label.

I do consider this task to be a ‘personal blocker’ for new Vector deployment to Russian Wikipedia. It is unacceptable that a component with this much prominence is violating WCAG A level at the time when it is already hard to persuade editors to follow WCAG.

Change 952289 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/UniversalLanguageSelector@master] Focus ULS button when the language menu is closed with Escape

https://gerrit.wikimedia.org/r/952289

Change 952289 abandoned by Jon Harald Søby:

[mediawiki/extensions/UniversalLanguageSelector@master] Focus ULS button when the language menu is closed with Escape

Reason:

per comment, filing in GitHub instead

https://gerrit.wikimedia.org/r/952289

jhsoby changed the task status from Open to In Progress.Aug 28 2023, 10:57 AM
jhsoby claimed this task.
abi_ triaged this task as Low priority.
abi_ moved this task from In Review to Done on the Language-Team (Language-2023-July-September) board.

Deployed, and tested on translatewiki.net