Sticky user menu is invisible but still clickable after scrolling to top
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Nardog
	Dec 13 2022, 5:34 PM

Description

Steps to replicate the issue (include links if applicable):

Open a page in Vector 2022
Scroll down so the sticky header appears
Open the user menu
Scroll to top so the the sticky header disappears
Hover the mouse over where the user menu was

What happens?:
The user menu is invisible (transparent) but lays over the page content and the links can still be clicked.

What should have happened instead?:
The user menu actually disappears.

QA Results - Beta

AC	Status	Details
1	✅	T325083#9503405

QA Results - Prod

AC	Status	Details
1	✅	T325083#9540481

Details

	Subject	Repo	Branch	Lines +/-
	Deactivate sticky header menus and search when sticky header is hidden attempt 2	mediawiki/skins/Vector	master	+11 -4
	Deactivate sticky header menus and search when sticky header is hidden	mediawiki/skins/Vector	master	+11 -4

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		ovasileva	T317884 [EPIC] Vector 2022 post-deployment work
Open		ovasileva	T317632 [EPIC] Visual refinements pt2
Resolved	BUG REPORT	ovasileva	T325083 Sticky user menu is invisible but still clickable after scrolling to top

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2022, 5:35 PM

Jdlrobson added a project: Web-Team-Backlog.Dec 14 2022, 4:37 PM

Jdlrobson moved this task from Incoming to Search on the Desktop Improvements (Vector 2022) board.

@Nardog thanks for catching this

• alexhollender_WMF updated the task description. (Show Details)Dec 19 2022, 2:24 PM

• alexhollender_WMF added a parent task: T317884: [EPIC] Vector 2022 post-deployment work.Dec 19 2022, 2:26 PM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jan 5 2023, 9:30 PM

matmarex subscribed.Jan 25 2023, 12:14 PM

ovasileva triaged this task as Medium priority.Mar 15 2023, 4:53 PM

ovasileva moved this task from Not ready to estimate to Current Quarter on the Web-Team-Backlog board.

ovasileva moved this task from Current Quarter to Web Team FY2022-23 Q4 Sprint 2 on the Web-Team-Backlog board.Apr 3 2023, 4:27 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2); removed Web-Team-Backlog.

ovasileva lowered the priority of this task from Medium to Low.Apr 17 2023, 5:48 PM

LGoto set the point value for this task to 3.Apr 17 2023, 5:51 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).Apr 24 2023, 1:59 PM

Jdlrobson raised the priority of this task from Low to Medium.May 9 2023, 5:00 PM

Jdlrobson moved this task from Incoming to Web Team FY2022-23 Q4 Sprint 4 on the Web-Team-Backlog board.

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4); removed Web-Team-Backlog.

Jdrewniak merged a task: T336159: Vector-2022 sticky header causes "clickjacking".May 9 2023, 5:01 PM

Jdrewniak added a subscriber: ZauberViolino.

As I have said in T336159, .uls-dialog-sticky-hide #vector-sticky-header { display: none; } should solve the problem. I was testing the new Vector skin these days and got "clickjacked" for, like, three times. Hard to imagine how many editors are affected by this.

Jdlrobson edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4).May 25 2023, 5:02 PM

LGoto edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6); removed Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5).Jun 5 2023, 5:43 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6).Jun 20 2023, 5:09 PM

Jdlrobson edited parent tasks, added: T317632: [EPIC] Visual refinements pt2; removed: T317884: [EPIC] Vector 2022 post-deployment work.Jun 28 2023, 12:29 AM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1), Desktop Improvements (Vector 2022).Jun 29 2023, 5:56 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2).Jul 17 2023, 5:44 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3).Jul 31 2023, 5:58 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4).Aug 14 2023, 9:22 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Aug 28 2023, 1:56 PM

ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Aug 28 2023, 5:24 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5).Aug 31 2023, 4:37 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6).Sep 11 2023, 9:49 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 11 2023, 3:52 PM

JohanahoJ subscribed.Oct 14 2023, 7:07 AM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3).Nov 6 2023, 6:57 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q2 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4).Nov 20 2023, 6:38 PM

Jdlrobson moved this task from Incoming to Doing on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:03 PM

Jdlrobson moved this task from Doing to Incoming on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:06 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q2 Sprint 5).Dec 4 2023, 8:46 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 12:20 AM

ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 9:43 AM

ovasileva mentioned this in T354495: Dropdown of sticky search form reacts to mouse events when page scrolled to top, albeit invisible.Jan 11 2024, 6:16 PM

ovasileva raised the priority of this task from Medium to High.Jan 11 2024, 6:19 PM

bwang claimed this task.Jan 16 2024, 5:28 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 1).Jan 16 2024, 6:08 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 18 2024, 2:42 PM

Change 991646 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Deactivate sticky header menus and search when sticky header is hidden

https://gerrit.wikimedia.org/r/991646

gerritbot added a project: Patch-For-Review.Jan 18 2024, 8:25 PM

bwang moved this task from Ready for Development to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 18 2024, 8:25 PM

bwang removed bwang as the assignee of this task.Jan 18 2024, 8:57 PM

bwang subscribed.

Jdlrobson moved this task from Code Review to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 29 2024, 4:14 PM

bwang changed the point value for this task from 3 to 1.Jan 29 2024, 6:45 PM

bwang moved this task from Ready for Development to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 29 2024, 7:01 PM

Change 991646 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Deactivate sticky header menus and search when sticky header is hidden

https://gerrit.wikimedia.org/r/991646

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 30 2024, 12:58 AM

Jdlrobson assigned this task to Edtadros.Jan 30 2024, 1:06 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2024, 1:30 AM

@bwang I missed something in code review - which explains why Pixel was not working - it was hitting a JavaScript error and cryptically reporting it.

Jdlrobson assigned this task to bwang.Jan 30 2024, 5:39 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.

Change 994145 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Deactivate sticky header menus and search when sticky header is hidden attempt 2

https://gerrit.wikimedia.org/r/994145

Change 994145 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Deactivate sticky header menus and search when sticky header is hidden attempt 2

https://gerrit.wikimedia.org/r/994145

bwang removed bwang as the assignee of this task.Jan 30 2024, 6:14 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.

Change 994145 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Deactivate sticky header menus and search when sticky header is hidden attempt 2

https://gerrit.wikimedia.org/r/994145

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 30 2024, 8:00 PM

Jdlrobson assigned this task to Edtadros.Jan 30 2024, 10:21 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Open a page in Vector 2022
Scroll down so the sticky header appears
Open the user menu
Scroll to top so the the sticky header disappears
Hover the mouse over where the user menu was
✅ AC1: The user menu actually disappears, it does not over the page content with links that can still be clicked.