When a mentor gets locked, mark them as away
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Dec 13 2022, 6:33 PM

Description

In T318819: When a mentor gets blocked, mark them as away, we ensured that blocked mentors are marked as away for the duration of the block. However, at Wikimedia wikis, users can also be globally locked. A global lock has similar impact to a block (locked users are effectively unable to participate in mentorship), but it impacts all Wikimedia wikis at once.

We decided to treat locked mentors in the same way as we already treat blocked mentors (see T318819).

Acceptance criteria

Given a Mentor receives a global lock,
Then their Mentor status is automatically set to "Away". The mentor cannot mark as active via Special:MentorDashboard.

Given a Mentor receives a global llock and their Mentor status is set to "Away",
Then if/when the lock is over, they have the option to set their Mentor status as "Active" (and they will have the same mentees as before the block).

Details

	Subject	Repo	Branch	Lines +/-
	MentorStatusManager: Treat locked mentors as away	mediawiki/extensions/GrowthExperiments	master	+14 -1

Customize query in gerrit

Related Objects

Mentioned In: T325135: Add caching to MentorStatusManager
T325134: MentorStatusManager: Automatically away users are marked as away until TODAY
Mentioned Here: T325134: MentorStatusManager: Automatically away users are marked as away until TODAY
T325135: Add caching to MentorStatusManager
T318819: When a mentor gets blocked, mark them as away

Event Timeline

Urbanecm_WMF created this task.Dec 13 2022, 6:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2022, 6:33 PM

Urbanecm_WMF triaged this task as Medium priority.Dec 13 2022, 6:33 PM

Urbanecm_WMF added subscribers: Dyolf77_WMF, KStoller-WMF, Trizek-WMF.

Change 867687 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorStatusManager: Treat locked mentors as away

https://gerrit.wikimedia.org/r/867687

gerritbot added a project: Patch-For-Review.Dec 13 2022, 6:46 PM

Urbanecm_WMF changed the task status from Open to In Progress.Dec 13 2022, 6:47 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Dec 13 2022, 7:15 PM

This will display as "Your primary mentor, FooBar, is currently away until <right now>." which seems confusing. The same is true for blocks as well.

Not related to the task but getEffectiveMentorForUser() is called something like 10 times to display the homepage (mostly because it is invoked by canRender() which is used quite a bit). It should really have an in-process cache.

Change 867687 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorStatusManager: Treat locked mentors as away

https://gerrit.wikimedia.org/r/867687

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 14 2022, 6:01 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2022, 6:30 AM

@Etonkovidova Not sure how easy it is for you to test behavior wrt locked users. Feel free to ping me if you need one of your testing accounts locked.

Urbanecm_WMF mentioned this in T325134: MentorStatusManager: Automatically away users are marked as away until TODAY.Dec 14 2022, 9:11 AM

In T325087#8465636, @Tgr wrote:

This will display as "Your primary mentor, FooBar, is currently away until <right now>." which seems confusing. The same is true for blocks as well.

Not related to the task but getEffectiveMentorForUser() is called something like 10 times to display the homepage (mostly because it is invoked by canRender() which is used quite a bit). It should really have an in-process cache.

Good points. Filled as T325135: Add caching to MentorStatusManager and T325134: MentorStatusManager: Automatically away users are marked as away until TODAY respectively.