Change 867694 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Thanks@master] Expose thanks statistic on special contributions page

https://gerrit.wikimedia.org/r/867694

Change 867723 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Allow extensions to add to contribution statistics

https://gerrit.wikimedia.org/r/867723

This is how it looks on the Growth homepage (not shown by default yet in most wikis): https://en.wikipedia.org/w/index.php?title=Special:Homepage&source=personaltoolslink&namespace=0&new-impact=1

Might make sense to align looks (code not so much, the Growth cards are in Vue), especially the icon.

@Volker_E it looks like OOUI does not have the required icon. Could it be added to the interactions icon pack?

In T325095#8469618, @Tgr wrote:

This is how it looks on the Growth homepage (not shown by default yet in most wikis): https://en.wikipedia.org/w/index.php?title=Special:Homepage&source=personaltoolslink&namespace=0&new-impact=1

Might make sense to align looks (code not so much, the Growth cards are in Vue), especially the icon.

I actually rather think we shouldn't present it in two places. If homepage has added similar content, I'd rather not have all the boxes on Special:Contribs (or at least not at the top), which already has a bar that most people keep and leave collapsed for the most part and which takes up quite enormous space otherwise. I don't per se want to call it noise - edit count is clearly something we associate with Contribs by the fact English WP if no others links Xtools at the bottom - but anything but edit count really strays from the mission of Special:Contribs I think. And it is definitely overwhelming in size with the current prototypes at T324166#8462073.

(I am happy to move this comment there if desired.)

This may be fine for "newcomers", but for prolific users it could have a performance impact. Special:Contribs is used frequently. I think it may be best to design these stats with only quick lookups in mind, such as edit count, user groups, registration date, etc. Anything that could potentially slow down Special:Contribs for the end user (and their workflow) is probably not ideal. You should at least cache the result, but it then it's potentially wrong and misleading. I.e. we have some long-term abusers who only Thank users, and never actually edit. It would be awesome to go to Special:Contribs and quickly see that they've only thanked (and made no edits), but what if it's cached at a value of zero? Then I wouldn't think to check the actual log, and they go under the radar. Perhaps that's an edge case, but anyway as for performance I'm mainly just trying to think ahead. If we add Thanks, people will want other various stats too. Raw counts on every page load should be avoided if possible.

There are only so many code paths for changing the number of thanks a user got (ApiThank, and maybe log supression), proper cache invalidation wouldn't be super hard.

My general feeling is that MediaWiki is really missing a user profile / dashboard kind of thing, but Special:Contributions isn't that. The closest thing we have today is the first tab of Special:Preferences (although that's only visible for yourself).

In T325095#8469630, @Izno wrote:

I actually rather think we shouldn't present it in two places. If homepage has added similar content, I'd rather not have all the boxes on Special:Contribs

The Thanks extension shouldn't depend on another unrelated extension for displaying its data, IMO.

I agree with @MusikAnimal, number of thanks received is not really a useful metric to me as a Wikipedian (who still patrols, does admin stuff, etc.). The technical tax of it (both doing the query + added complexity of introducing a new hook) is not really worth the gain.

In addition to the already-mentioned Special:Homepage, there is Special:Impact where you can see this information for yourself or another user, and we may end up allowing users to embed this info in e.g. their user page using transclusion (T219025).

Both Special:Homepage and Special:Impact make use of precomputed, cached data, so if you did want to add something to Special:Contributions, it might make sense to use that instead of doing re-generating the queries, and trying to figure out ways around the performance issues. The relevant code is in the UserImpact set of classes in GrowthExperiments.

I think this task should probably be stalled until T324166 is done and there is a clear idea of what we are delivering.

In T325095#8470014, @Ladsgroup wrote:

I agree with @MusikAnimal, number of thanks received is not really a useful metric to me as a Wikipedian (who still patrols, does admin stuff, etc.).

As a Wikipedian (who still patrols, does admin stuff, etc.), I like to see the number of thanks sent to me. This is how I know that my volunteer work matters. :)

I usually check other people's contributions, I know what I contributed :D That sounds like a good place to put in Special:Contribute instead of Special:Contributions

In T325095#8498737, @Ladsgroup wrote:

That sounds like a good place to put in Special:Contribute instead of Special:Contributions

Maybe, if people know about it. And you made me discover it. :)

The plan is to slowly roll it out to more places and make it linked in user tools and such. Here is what I mean: https://en.m.wikipedia.org/wiki/Special:Contribute

Change 867694 abandoned by Jdlrobson:

[mediawiki/extensions/Thanks@master] Expose thanks statistic on special contributions page

Reason:

Abandoning for now given there is too much disagreement on ticket.

https://gerrit.wikimedia.org/r/867694

Blocked on T324166