Page MenuHomePhabricator

Updated tools menu for Vector 2022 breaks on-wiki scripts
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • A problem similar to T315639 appears: The Wikidata description we use for controlling Wikidata from within a Wikipedia article is moved to a location that does not fit:

Screenshot 2022-12-13 at 21-03-01 Heinrich Heine – Wikipedia.png (2,418×1,446 px, 1 MB)

What should have happened instead?:

  • It should rather look like this:

Screenshot 2022-12-13 at 21-09-04 Heinrich Heine – Wikipedia.png (2,418×1,446 px, 1 MB)

Edit: Also mentioned at https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements#c-Aschmidt-20221213202600-Page_tools_move_breaks_user_scripts

Event Timeline

Aschmidt updated the task description. (Show Details)

@Aschmidt could you share the code for the gadget you are using here?

@Aschmidt This issue is caused by this revision to the script: https://www.wikidata.org/w/index.php?title=User:Yair_rand/WikidataInfo.js&oldid=1711684895
I've tested the previous version locally and it works well (and also places the info in the contentSub area, which looks much better :)

Screen Shot 2022-12-14 at 9.57.30 AM.png (2,772×1,624 px, 1 MB)

I left a comment on the talk page to revert the edit.

@Jdrewniak , thank you for looking into this and for contacting @Yair_rand both on this platform and on Wikidata. I would be grateful if you please could fix the issue before the new version of Vector 2022 goes live. Also, I had not realised yet that #contentSub is back again. That's even better.

You can also use mw.util.addSubtitle now for a more reliable way to add content to the subtitle. Works across all skins.

@Jdrewniak , your proposed fix to WikidataInfo has been accepted, and the sciript now works as expected:

{F35870510}

Thanks again! I think we could close this issue?

Jdlrobson claimed this task.