💥️ Adjust the PatchStatement use case to apply patches using a generic JsonPatcher
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Dec 14 2022, 3:37 PM

Description

make use of the generic StatemenPatcher created via T325179
solution is outlined in a proof-of-concept, but without a separate patcher:
- serialize the statement
- apply the patch (and catch Exceptions)
- validate the patched statement and return ErrorResponse if not successful

Details

	Subject	Repo	Branch	Lines +/-
	REST: Remove unused patch classes	mediawiki/extensions/Wikibase	master	+0 -378
	REST: Use generic JsonPatcher in PatchItemStatement	mediawiki/extensions/Wikibase	master	+224 -180

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T335067 Epic: Wikidata Query Service stabilization
Resolved	Lydia_Pintscher	T314503 rollout of the new Wikibase REST API to Wikidata
Open	None	T316718 Errors in Wikibase REST API
Resolved	Ollie.Shotton_WMDE	T324088 💥️ Improve error reporting for invalid statement data in REST API (missing field or invalid value)
Resolved	Jakob_WMDE	T325182 💥️ Adjust the PatchStatement use case to apply patches using a generic JsonPatcher

Event Timeline

Silvan_WMDE created this task.Dec 14 2022, 3:37 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptDec 14 2022, 3:37 PM

Silvan_WMDE mentioned this in T325079: 💥️ Decide how to deal with missing/invalid field errors in patched statements.Dec 14 2022, 3:55 PM

Jakob_WMDE mentioned this in T325190: 💥️ Handle invalid and missing field errors for the PATCH endpoint.Dec 14 2022, 3:58 PM

Silvan_WMDE renamed this task from 💥️ Adjust the PatchStatemtent use case to apply patches using a generic JsonPatcher to 💥️ Adjust the PatchStatement use case to apply patches using a generic JsonPatcher.Dec 14 2022, 4:12 PM

Jakob_WMDE claimed this task.Dec 15 2022, 3:23 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 19) board.

Change 868728 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use generic JsonPatcher in PatchItemStatement

https://gerrit.wikimedia.org/r/868728

gerritbot added a project: Patch-For-Review.Dec 16 2022, 5:27 PM

Change 869189 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove unused patch classes

https://gerrit.wikimedia.org/r/869189

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 19) board.Dec 19 2022, 11:31 AM

Change 868728 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use generic JsonPatcher in PatchItemStatement