Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributions
Closed, ResolvedPublic
Actions

Description

Background

WikimediaMessages adds some links to the infobox on Special:Contributions, via this script, which is loaded via handling the SpecialContributionsBeforeMainOutput hook here.

As the hooks's name would suggest, this is only run on Special:Contributions, and not Special:DeletedContributions. Therefore, these links would not show in the infobox added in T318463: IP Info accordion should show up on the Special:DeletedContributions.

We can instead use the SpecialPageBeforeExecute hook for both pages.

Acceptance criteria

WikimediaMessages adds the same links to Special:Contributions and Special:DeletedContributions
WikimediaMessages adds the same links to Special:Contributions as it did before this task
The feedback link on Special:Block works the same as before (it is also added via SpecialPageBeforeExecute)

Details

	Subject	Repo	Branch	Lines +/-
	Add IPInfo links via SpecialPageBeforeExecute hook	mediawiki/extensions/WikimediaMessages	master	+48 -36

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Feature	Cyndymediawiksim	T318463 IP Info accordion should show up on the Special:DeletedContributions
		Resolved		Tchanders	T325214 Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributions

Event Timeline

Tchanders created this task.Dec 14 2022, 5:27 PM

Change 868137 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/WikimediaMessages@master] Add IPInfo links via SpecialPageBeforeExecute hook

https://gerrit.wikimedia.org/r/868137

gerritbot added a project: Patch-For-Review.Dec 14 2022, 5:34 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 14 2022, 5:35 PM

Tchanders updated the task description. (Show Details)Dec 14 2022, 5:45 PM

Tchanders mentioned this in T318463: IP Info accordion should show up on the Special:DeletedContributions.Dec 19 2022, 1:51 PM

• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 19 2022, 4:19 PM

The patch does not appear to have been reviewed yet.

Change 868137 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Add IPInfo links via SpecialPageBeforeExecute hook

https://gerrit.wikimedia.org/r/868137

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 21 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2022, 4:29 PM

@dom_walden @GMikesell-WMF I think the acceptance criteria cover all that needs testing here, but let @AGueyte or me know if anything is unclear.

WikimediaMessages adds the same links to Special:Contributions and Special:DeletedContributions

Yes, comparing these two pages on beta.

WikimediaMessages adds the same links to Special:Contributions as it did before this task

Yes, comparing beta to an old IPInfo on local.

The feedback link on Special:Block works the same as before (it is also added via SpecialPageBeforeExecute)

The feedback link still appears.

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (7ae7f99) 07:43, 2 January 2023.

Tchanders mentioned this in T318464: IP Info accordion should show count of deleted edits to those who have access.Jan 18 2023, 6:23 PM

Tchanders closed this task as Resolved.Mar 21 2023, 2:13 PM

Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributionsClosed, ResolvedPublicActions