[Mobile] Opened Search preview requires horizontal scrolling for all articles' snippets
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Dec 15 2022, 1:25 AM

Description

Found when testing T320646

On betalabs go to Special:Search
Perform search and click on the arrow on the first result to open the Search preview.
The Search preview will open; you may scroll horizontally to see an article's lead image, an article's description etc (CORRECT behavior)

Comparing with the AC in T320646, the following issues were found:

DONE (1) When the Search preview is open for one article, all other article snippets will occupy the same width as the article with the opened Search preview, so the vertical scrolling will be required for all articles' snippets. See the animated gif below:

horizontal_scroll.gif (755×591 px, 1010 KB)

(2) With the Search preview open, the arrow will be placed at the end of the expanded snippet for all articles on the search result page.

mockup	enwiki betalabs

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Opened Search preview requires horizontal scrolling for all articles snippets	mediawiki/extensions/SearchVue	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T320646: [M] Mobile: Show article lead image in the quick view.
Mentioned Here: T320646: [M] Mobile: Show article lead image in the quick view.

Event Timeline

Etonkovidova created this task.Dec 15 2022, 1:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2022, 1:25 AM

Etonkovidova mentioned this in T320646: [M] Mobile: Show article lead image in the quick view..Dec 15 2022, 2:01 AM

CBogen added a project: Structured-Data-Backlog.Dec 15 2022, 2:14 PM

vadim-kovalenko claimed this task.Dec 19 2022, 10:55 AM

Change 868505 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/extensions/SearchVue@master] Opened Search preview requires horizontal scrolling for all articles snippets

https://gerrit.wikimedia.org/r/868505

gerritbot added a project: Patch-For-Review.Dec 19 2022, 3:07 PM

vadim-kovalenko moved this task from Triage to Current Work on the Structured-Data-Backlog board.Dec 19 2022, 3:15 PM

vadim-kovalenko edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

vadim-kovalenko moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.

CBogen edited projects, added SDAW-Search-Improvements (Milestone 3: QuickView mobile); removed SDAW-Search-Improvements.Jan 3 2023, 2:09 PM

I tried to replicate this with Browserstack and also the mobile emulator and I cannot manage to replicate it anymore.

Due to numerous changes in the CSS, I expect this to have been fixed already. I am NOT merging the fix until we have a way to reproduce it.

i am moving this into QA so that Elena can check it again (I spoke with her directly).

SimoneThisDot moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 3 2023, 4:03 PM

In T325259#8495443, @SimoneThisDot wrote:

I tried to replicate this with Browserstack and also the mobile emulator and I cannot manage to replicate it anymore.

Due to numerous changes in the CSS, I expect this to have been fixed already. I am NOT merging the fix until we have a way to reproduce it.

i am moving this into QA so that Elena can check it again (I spoke with her directly).

Yes, I re-checked - the issues are not present anymore, thx @SimoneThisDot.

Change 868505 abandoned by Vadim Kovalenko:

[mediawiki/extensions/SearchVue@master] Opened Search preview requires horizontal scrolling for all articles snippets

Reason:

Patch is irrelevant now.