Page MenuHomePhabricator

The final preference in a section should not have a horizontal grey line on mobile web
Closed, ResolvedPublic

Description

In T324227 we added new horizontal lines to Special:Preferences on mobile web to separate individual preferences. It doesn't make sense to display these after the final preference in a section, or at the end of the page, since there is already a clear divider in the section heading (or end of page).

Screenshot 2022-12-15 at 12.26.05.png (616×736 px, 65 KB)

Screenshot 2022-12-15 at 12.26.14.png (790×726 px, 121 KB)

Technical information

TBD

Testing and QA steps

  • Access a mobile Wikimedia site and log in
  • Navigate to the sidebar and select Settings
  • Turn on Advanced mode
  • Click 'Open preferences' in Settings
  • Open a submenu (e.g. User Profile)
  • Check whether a horizontal grey line is shown at the end of sections and at the bottom of the submenu

Acceptance Criteria

  • Horizontal grey lines should display between each preference, except for at the end of sections and the end of the submenu page.

Event Timeline

I don't see this error showing up in production or in my local development environment. @Samwalton9 could you please confirm this?

I don't see this error showing up in production or in my local development environment. @Samwalton9 could you please confirm this?

Oh, yeah, hm. It looks like this must have been fixed somewhere else.