Page MenuHomePhabricator

CI composer-package-php82-docker needs newer composer/symfony components
Closed, ResolvedPublic

Description

When running php8.2 jobs with composer-package-php82-docker for T314093 there are some notice in the logs

https://integration.wikimedia.org/ci/job/composer-package-php82-docker/10/console

Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/vendor/symfony/console/Command/DumpCompletionCommand.php:48
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/vendor/symfony/console/Command/DumpCompletionCommand.php:56
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/src/Composer/Autoload/AutoloadGenerator.php:875
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/src/Composer/Autoload/AutoloadGenerator.php:880
+ composer --ansi validate
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/vendor/symfony/console/Command/DumpCompletionCommand.php:48
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/vendor/symfony/console/Command/DumpCompletionCommand.php:56
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/src/Composer/Autoload/AutoloadGenerator.php:875
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/src/Composer/Autoload/AutoloadGenerator.php:880
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/vendor/composer/spdx-licenses/src/SpdxLicenses.php:306
Deprecation Notice: Using ${var} in strings is deprecated, use {$var} instead in phar:///usr/bin/composer/vendor/composer/spdx-licenses/src/SpdxLicenses.php:312
./composer.json is valid, but with a few warnings

The warning on DumpCompletionCommand.php should be fixed with https://github.com/symfony/console/commit/06974380c667d7d8e3cd0f24bf51f816a71ca6c6, which seems to be part of symfony/console 5.4.9

Later on the jobs is locking

Locking symfony/console (v5.4.16)

So this seems happen within the package and not in the test run

SpdxLicenses.php was fixed in https://github.com/composer/spdx-licenses/commit/c49d8700039dc3ff27030faeb4e0d12092498863 (spdx-licenses 1.5.7) and that is used later

AutoloadGenerator.php was fixed in https://github.com/composer/composer/commit/c27dca83ef21bd44c41c1a60dd2e7ab1afa70a13 which seems includes in composer 2.2.13

Not sure what composer the package is using, but needs some updates

Event Timeline

Not sure what composer the package is using, but needs some updates

2.3.3 since rCICFf03c29f2bf8e: dockerfiles: [composer-scratch] Upgrade composer to 2.3.3 and cascade

I would concur after ~8 months, it's probably due a bump!

Reedy triaged this task as High priority.Jan 3 2023, 10:16 PM