Page MenuHomePhabricator
Create Task
Maniphest T325381

stashbot: timestamps in SAL messages can be interpreted as ticket links
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • go to an IRC channel with active !log (SAL) command
  • paste a line that contains a timestamp including 'T' and an integer: example: <joal>!log rerun webrequest failed jobs for hour 2022-12-08-T11:00Z with updated workflow (no dataloss checks)

What happens?:

A comment with the log line is added to unrelated ticket "T11". https://phabricator.wikimedia.org/T11#8454014

What should have happened instead?:

Nothing should happen on the unrelated old ticket.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
bot: Ignore Phabricator ids that are less than 3 digitslabs/tools/stashbotmaster+40 -1
Customize query in gerrit

Related Objects

Event Timeline

Dzahn created this task.Dec 16 2022, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2022, 6:19 PM
Dzahn triaged this task as Low priority.Dec 16 2022, 6:21 PM
Dzahn updated the task description. (Show Details)
bd808 subscribed.EditedDec 16 2022, 6:29 PM
[06:12:26] <_joe_>	 bd808: you can probably just look at the capture length?
[06:12:40] <_joe_>	 there not much chance anyone edits a task under 4 digits

This seems like a relatively simple and effective solution. Things between T1: Get puppet runs into logstash and T2001: [DO NOT USE] Documentation is out of date, incomplete (tracking) [superseded by #Documentation] are unlikely to be targeted by !log messages. @Dzahn pointed out on IRC that just ignoring T1: Get puppet runs into logstash..T23: Identify features Gerrit users would miss in Phabricator would also address this particular case.

bd808 changed the task status from Open to In Progress.Dec 16 2022, 6:43 PM
bd808 claimed this task.
bd808 moved this task from Backlog to Accepted on the Stashbot board.
Restricted Application added a project: User-bd808. · View Herald TranscriptDec 16 2022, 6:43 PM
gerritbot added a comment.Dec 16 2022, 7:11 PM

Change 868735 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[labs/tools/stashbot@master] bot: Ignore Phabricator ids that are less than 3 digits

https://gerrit.wikimedia.org/r/868735

gerritbot added a project: Patch-For-Review.Dec 16 2022, 7:11 PM
gerritbot added a comment.Dec 16 2022, 10:26 PM

Change 868735 merged by jenkins-bot:

[labs/tools/stashbot@master] bot: Ignore Phabricator ids that are less than 3 digits

https://gerrit.wikimedia.org/r/868735

Stashbot added a comment.Dec 16 2022, 10:29 PM

Mentioned in SAL (#wikimedia-cloud) [2022-12-16T22:29:25Z] <bd808> Updated to 64a78ad (T325381)

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2022, 10:30 PM
bd808 closed this task as Resolved.Dec 16 2022, 10:31 PM
[22:29]  <    bd808> !log tools.stashbot Updated to 64a78ad (T325381)
[22:29]  < stashbot> Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.stashbot/SAL
[22:29]  < stashbot> T325381: stashbot: timestamps in SAL messages can be interpreted as ticket links - https://phabricator.wikimedia.org/T325381
[22:30]  <    bd808> !log tools.stashbot testing: 2022-12-08-T11:00Z should not update any Phabricator tasks
[22:30]  < stashbot> Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.stashbot/SAL
bd808 mentioned this in rLTST64a78ad85e3c: bot: Ignore Phabricator ids that are less than 3 digits.Dec 17 2022, 2:58 AM
Dzahn awarded a token.Dec 17 2022, 12:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL