Page MenuHomePhabricator
Create Task
Maniphest T325386

Unwanted results returned after search and then infinite scroll in participants list
Closed, ResolvedPublicBUG REPORT
Actions

Description

WHEN searching a participant list with more than 20 participants
AND participant is not in the first 20 loaded in
AND participant is not in the first results returned in the search
AND user uses infinite scroll only after the search
THEN unwanted results will return in the search

Screen Recording 2022-12-16 at 1.16.15 PM.gif (2×1 px, 3 MB)

Details

SubjectRepoBranchLines +/-
Fix participant search for >20 participantsmediawiki/extensions/CampaignEventsmaster+14 -17
Customize query in gerrit

Event Timeline

vaughnwalters created this task.Dec 16 2022, 7:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2022, 7:28 PM
vaughnwalters updated the task description. (Show Details)Dec 16 2022, 7:31 PM
ldelench_wmf subscribed.Dec 16 2022, 7:34 PM
Daimona claimed this task.Dec 19 2022, 1:52 PM
gerritbot added a comment.Dec 19 2022, 1:59 PM

Change 869219 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix participant search for >20 participants

https://gerrit.wikimedia.org/r/869219

gerritbot added a project: Patch-For-Review.Dec 19 2022, 1:59 PM
Daimona edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools.Dec 19 2022, 2:00 PM
Daimona moved this task from Needs Input / Design in progress to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
gerritbot added a comment.Jan 5 2023, 2:33 PM

Change 869219 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix participant search for >20 participants

https://gerrit.wikimedia.org/r/869219

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 5 2023, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 5 2023, 3:30 PM
Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jan 5 2023, 3:37 PM

This is now fixed, and everything search-related should hopefully be working now.

vaughnwalters closed this task as Resolved.Jan 5 2023, 6:31 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

This is functioning correctly now, as seen in the gif below. I am marking this as Done.

Screen Recording 2023-01-05 at 12.27.36 PM.gif (1×1 px, 1 MB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL